[testing] file report: notifs go through alerting-infra repo #7309
+104
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7303 since I fixed the pre-normalized alert thing earlier than expected
Format is a bit weird since the alerting infra isn't really set up for notification style alerts where its never really closed by anything, so it just sends a "resolved" alert right after to prevent open issues from cluttering up the issue list. Not sure if this is the best way
TODO: move secrets to aws secret manager?
Testing:
Ran the script a couple of times and saw that issues got created and closed in the alerting repo, also put pull request trigger to see if that would work too and it did