Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit ed78e3b

Browse files
authored
Add TorchData as hard dependency (#1985)
* Add TorchData as hard dependency * Add install_torchdata.sh as pre-script * Add conda constraint * Fix tests
1 parent b3390fb commit ed78e3b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+171
-159
lines changed

.circleci/config.yml

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.circleci/config.yml.in

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ binary_common: &binary_common
4848
description: "PyTorch version to build against; by default, use a nightly"
4949
type: string
5050
default: ""
51+
torchdata_version:
52+
description: "TorchData version to build against; by default, use a nightly"
53+
type: string
54+
default: ""
5155
# Don't edit these
5256
python_version:
5357
description: "Python version to build against (e.g., 3.8)"
@@ -56,6 +60,7 @@ binary_common: &binary_common
5660
PYTHON_VERSION: << parameters.python_version >>
5761
BUILD_VERSION: << parameters.build_version >>
5862
PYTORCH_VERSION: << parameters.pytorch_version >>
63+
TORCHDATA_VERSION: << parameters.torchdata_version >>
5964
CU_VERSION: cpu
6065
MACOSX_DEPLOYMENT_TARGET: 10.9
6166

.circleci/unittest/linux/scripts/install.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env bash
22

33
unset PYTORCH_VERSION
4+
unset TORCHDATA_VERSION
45
# For unittest, nightly PyTorch is used as the following section,
56
# so no need to set PYTORCH_VERSION.
67
# In fact, keeping PYTORCH_VERSION forces us to hardcode PyTorch version in config.

.circleci/unittest/windows/scripts/install.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env bash
22

33
unset PYTORCH_VERSION
4+
unset TORCHDATA_VERSION
45
# For unittest, nightly PyTorch is used as the following section,
56
# so no need to set PYTORCH_VERSION.
67
# In fact, keeping PYTORCH_VERSION forces us to hardcode PyTorch version in config.

.github/workflows/build-conda-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
conda-package-directory: packaging/torchtext
2828
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-conda-m1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
conda-package-directory: packaging/torchtext
2828
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-conda-macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
conda-package-directory: packaging/torchtext
2828
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-wheels-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
smoke-test-script: test/smoke_tests/smoke_tests.py
2828
package-name: torchtext

.github/workflows/build-wheels-m1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
package-name: torchtext
2828
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-wheels-macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
matrix:
2323
include:
2424
- repository: pytorch/text
25-
pre-script: ""
25+
pre-script: packaging/install_torchdata.sh
2626
post-script: ""
2727
package-name: torchtext
2828
smoke-test-script: test/smoke_tests/smoke_tests.py

0 commit comments

Comments
 (0)