Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit 0f2849b

Browse files
authored
Unsupress params and tokenizer path in CLI (#1165)
1 parent 75b877a commit 0f2849b

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

torchchat/cli/cli.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,14 @@ def add_arguments_for_verb(parser, verb: str) -> None:
8686

8787
# WIP Features (suppressed from --help)
8888
_add_distributed_args(parser)
89-
_add_custom_model_args(parser)
9089
_add_speculative_execution_args(parser)
9190

9291

9392
# Add CLI Args related to model specification (what base model to use)
9493
def _add_model_specification_args(parser) -> None:
9594
model_specification_parser = parser.add_argument_group(
9695
"Model Specification",
97-
"(REQUIRED) Specify the base model. Args are mutually exclusive.",
96+
"A base model is required: `model` XOR `checkpoint-path`",
9897
)
9998
exclusive_parser = model_specification_parser.add_mutually_exclusive_group(
10099
required=True
@@ -112,7 +111,8 @@ def _add_model_specification_args(parser) -> None:
112111
default="not_specified",
113112
help="Use the specified model checkpoint path",
114113
)
115-
# See _add_custom_model_args() for more details
114+
115+
_add_custom_model_args(model_specification_parser)
116116
exclusive_parser.add_argument(
117117
"--gguf-path",
118118
type=Path,
@@ -411,8 +411,7 @@ def _add_distributed_args(parser) -> None:
411411
)
412412

413413

414-
# Add CLI Args related to custom model inputs (e.g. GGUF)
415-
# This feature is currently a [WIP] and hidden from --help
414+
# Add CLI Args related to custom model inputs
416415
def _add_custom_model_args(parser) -> None:
417416
parser.add_argument(
418417
"--params-table",
@@ -426,15 +425,13 @@ def _add_custom_model_args(parser) -> None:
426425
"--params-path",
427426
type=Path,
428427
default=None,
429-
help=argparse.SUPPRESS,
430-
# "Use the specified parameter file",
428+
help= "Use the specified parameter file, instead of one specified under torchchat.model_params",
431429
)
432430
parser.add_argument(
433431
"--tokenizer-path",
434432
type=Path,
435433
default=None,
436-
help=argparse.SUPPRESS,
437-
# "Use the specified model tokenizer file",
434+
help= "Use the specified model tokenizer file, instead of the one downloaded from HuggingFace",
438435
)
439436

440437

0 commit comments

Comments
 (0)