This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Revert "export.py: fix custom SDPA type conversion logic & re-enable for bfloat16" #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for bflo…" This reverts commit 3aba730.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1197
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 14070d9 with merge base 3aba730 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1193 -- trunk runner-et job https://github.com/pytorch/torchchat/actions/runs/11022084837/job/30610612304 is showing garbage output for fp16 and bf16, previous job had normal output. I suspect that #1193 fixes a real bug that was covering up a different bug, though; will investigate.