You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Obey training.planner.log_plan flag on if to log sharding plan (#3244)
Summary:
Pull Request resolved: #3244
## Why
Sharding plan can be verbose and we used to control if to log it via training.planner.log_plan, which creates NoopEmbeddingStats when is False and valid stats otherwise:
https://www.internalfb.com/code/fbsource/[375d786e20a4]/fbcode/apf/rec/distributed/parallel.py?lines=872-882
D74557713 adds a new logging on the raw sharding plan without following this flag. This diffs guards it with the flag.
## What
Only log the raw sharding plan when there is valid stats (i.e. not NoopEmbeddingStats).
Reviewed By: ge0405
Differential Revision: D79271421
fbshipit-source-id: bc16a5bf4349780a9f316a5f6ccc65489e77672a
0 commit comments