Skip to content

Generalize benchmark_module function #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generalize benchmark_module function #3223

wants to merge 1 commit into from

Conversation

SSYernar
Copy link
Contributor

Summary: Previously benchmark_module was compatible only with EmbeddingCollection and EmbeddingBagCollection modules. This change generalizes the function to take any nn.module and run benchmarks on given Sharding Types and Compile Modes. Additional module wrapper was introduced for Embedding modules including EC, EBC, QEC, QEBC to ensure the compatibility of ModelInput with given modules as they only take KeyedJaggedTensor for input.

Differential Revision: D78586820

@SSYernar @facebook-github-bot
Generalize benchmark_module function
ab65d0a 
Summary: Previously `benchmark_module`  was compatible only with `EmbeddingCollection` and `EmbeddingBagCollection` modules. This change generalizes the function to take any `nn.module` and run benchmarks on given Sharding Types and Compile Modes. Additional module wrapper was introduced for Embedding modules including `EC`, `EBC`, `QEC`, `QEBC` to ensure the compatibility of ModelInput with given modules as they only take `KeyedJaggedTensor` for input.

Differential Revision: D78586820
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78586820

@meta-cla Meta CLA
Copy link

meta-cla bot commented Aug 23, 2025

Hi @SSYernar!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SSYernar @facebook-github-bot