Skip to content

Commit 1587868

Browse files
authored
Add simpleFSDP numerics test to CI (#1911)
Add `torchtitan/experiments/simple_fsdp/tests/test_numerics.py` to CI
1 parent 7209894 commit 1587868

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

.github/workflows/integration_test_8gpu_flux.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ on:
55
branches: [ main ]
66
paths:
77
- 'torchtitan/experiments/flux/**'
8+
- '.github/workflows/integration_test_8gpu_flux.yaml'
89
pull_request:
910
paths:
1011
- 'torchtitan/experiments/flux/**'
12+
- '.github/workflows/integration_test_8gpu_flux.yaml'
1113

1214
concurrency:
1315
group: unit-test${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_number || github.ref }}

.github/workflows/integration_test_8gpu_simple_fsdp.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ on:
55
branches: [ main ]
66
paths:
77
- 'torchtitan/experiments/simple_fsdp/**'
8+
- '.github/workflows/integration_test_8gpu_simple_fsdp.yaml'
89
pull_request:
910
paths:
1011
- 'torchtitan/experiments/simple_fsdp/**'
12+
- '.github/workflows/integration_test_8gpu_simple_fsdp.yaml'
1113
schedule:
1214
# Runs every 12 hours
1315
- cron: '0 */12 * * *'
@@ -49,3 +51,6 @@ jobs:
4951
5052
mkdir artifacts-to-be-uploaded
5153
python -m torchtitan.experiments.simple_fsdp.tests.integration_tests artifacts-to-be-uploaded --ngpu 8
54+
55+
# Run the numerics unit tests of SimpleFSDP
56+
torchrun --nproc-per-node=8 -m pytest torchtitan/experiments/simple_fsdp/tests/test_numerics.py -v

.github/workflows/integration_test_8gpu_torchft.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ on:
55
branches: [ main ]
66
paths:
77
- 'torchtitan/components/ft.py'
8+
- '.github/workflows/integration_test_8gpu_torchft.yaml'
89
pull_request:
910
paths:
1011
- 'torchtitan/components/ft.py'
12+
- '.github/workflows/integration_test_8gpu_torchft.yaml'
1113
schedule:
1214
# Runs every 6 hours
1315
- cron: '0 */6 * * *'

.github/workflows/integration_test_8gpu_vlm.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ on:
55
branches: [ main ]
66
paths:
77
- 'torchtitan/experiments/vlm/**'
8+
- '.github/workflows/integration_test_8gpu_vlm.yaml'
89
pull_request:
910
paths:
1011
- 'torchtitan/experiments/vlm/**'
12+
- '.github/workflows/integration_test_8gpu_vlm.yaml'
1113
schedule:
1214
# Runs every 12 hours
1315
- cron: '0 */12 * * *'

0 commit comments

Comments
 (0)