Skip to content

Commit 4f8677b

Browse files
committed
update simplefsdp pass config
1 parent 1233902 commit 4f8677b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

torchtitan/train.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def __init__(self, job_config: JobConfig):
131131
print("Must use pytorch from unlanded https://github.com/pytorch/pytorch/pull/160282, e.g. torchtitan_conda_prod:5e4101faa448c2ee6b62ddd76ee08e8c")
132132
raise
133133

134-
# Configs from Ruisi
134+
# Configs from Ruisi
135135

136136
# set to 0.1 if you want to make bucketing more efficient with mixed dtype collectives
137137
torch._inductor.config.simplefsdp.relax_ratio = 0
@@ -140,10 +140,10 @@ def __init__(self, job_config: JobConfig):
140140
torch._inductor.config.simplefsdp.estimate_verbose = False
141141
torch._inductor.config.simplefsdp.save_estimation_path = "/mnt/mffuse/cache_ruisi/estimation_mast_"+job_config.model.flavor+".pkl"
142142
# set to True after the first communication estimation results are saved. This would reduce decision making time.
143-
torch._inductor.config.simplefsdp.load_cache = False
143+
torch._inductor.config.simplefsdp.load_cache = False
144144
torch._inductor.config.simplefsdp.enable_bucket_ir = True
145145
torch._inductor.config.simplefsdp.enable_reorder_ir = True
146-
torch._inductor.config.simplefsdp.simplefsdp_only = True # False for 2d True for 1d
146+
torch._inductor.config.simplefsdp.simplefsdp_only = False # False for 2d True for 1d
147147
torch._inductor.config.simplefsdp.peak_memory_offset = 0
148148
torch._inductor.config.simplefsdp.bucketing_type = "auto"
149149

0 commit comments

Comments
 (0)