Skip to content

Commit 9af9962

Browse files
authored
Merge branch 'main' into vmoens-patch-1
2 parents 79bb1c9 + e6fc189 commit 9af9962

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

advanced_source/pendulum.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
3434
In the process, we will touch three crucial components of TorchRL:
3535
36-
* `environments <https://pytorch.org/rl/reference/envs.html>`__
37-
* `transforms <https://pytorch.org/rl/reference/envs.html#transforms>`__
38-
* `models (policy and value function) <https://pytorch.org/rl/reference/modules.html>`__
36+
* `environments <https://pytorch.org/rl/stable/reference/envs.html>`__
37+
* `transforms <https://pytorch.org/rl/stable/reference/envs.html#transforms>`__
38+
* `models (policy and value function) <https://pytorch.org/rl/stable/reference/modules.html>`__
3939
4040
"""
4141

@@ -384,7 +384,7 @@ def _reset(self, tensordict):
384384
# convenient shortcuts to the content of the output and input spec containers.
385385
#
386386
# TorchRL offers multiple :class:`~torchrl.data.TensorSpec`
387-
# `subclasses <https://pytorch.org/rl/reference/data.html#tensorspec>`_ to
387+
# `subclasses <https://pytorch.org/rl/stable/reference/data.html#tensorspec>`_ to
388388
# encode the environment's input and output characteristics.
389389
#
390390
# Specs shape

intermediate_source/dist_tuto.rst

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ the following template.
4747
"""run.py:"""
4848
#!/usr/bin/env python
4949
import os
50+
import sys
5051
import torch
5152
import torch.distributed as dist
5253
import torch.multiprocessing as mp
@@ -66,8 +67,12 @@ the following template.
6667
if __name__ == "__main__":
6768
world_size = 2
6869
processes = []
69-
mp.set_start_method("spawn")
70-
for rank in range(world_size):
70+
if "google.colab" in sys.modules:
71+
print("Running in Google Colab")
72+
mp.get_context("spawn")
73+
else:
74+
mp.set_start_method("spawn")
75+
for rank in range(size):
7176
p = mp.Process(target=init_process, args=(rank, world_size, run))
7277
p.start()
7378
processes.append(p)
@@ -156,7 +161,8 @@ we should not modify the sent tensor nor access the received tensor before ``req
156161
In other words,
157162

158163
- writing to ``tensor`` after ``dist.isend()`` will result in undefined behaviour.
159-
- reading from ``tensor`` after ``dist.irecv()`` will result in undefined behaviour.
164+
- reading from ``tensor`` after ``dist.irecv()`` will result in undefined
165+
behaviour, until ``req.wait()`` has been executed.
160166

161167
However, after ``req.wait()``
162168
has been executed we are guaranteed that the communication took place,

0 commit comments

Comments
 (0)