Fix XPU and CUDA tables in profiler recipe. #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3393
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 862f092 with merge base 33a7401 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
AlannaBurke
requested changes
Jun 12, 2025
There was a problem hiding this comment.
I'm seeing broken tables: https://docs-preview.pytorch.org/pytorch/tutorials/3393/recipes/recipes/profiler_recipe.html
svekars
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a minor fix for some table formatting issues in the profiler_recipe file. Specifically, the CUDA and XPU tables after the first GPU profiling section were not being rendered similar to the other tables.
I also recognized that the current method of specifying
activities = [ProfilerActivity.CPU, ProfilerActivity.CUDA, ProfilerActivity.XPU]does not cause XPU profiling to be captured, but this seems more like an issue in Pytorch than in the tutorial, so I will file an issue in Pytorch to fix this.Checklist
cc @svekars @sekyondaMeta @AlannaBurke @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ZailiWang @ZhaoqiongZ @leslie-fang-intel @Xia-Weiwen @sekahler2 @CaoE @zhuhaozhe @Valentine233