Skip to content

Conversation

LTMeyer
Copy link
Contributor

@LTMeyer LTMeyer commented Sep 30, 2024

Fixes #3067

Description

Update the code provided in the tutorial.

  • Fix undefined variables model and optimizer;
  • Fix missing import of Stateful;
  • Fix the state_dict variable for correct loading.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @wconstab @osalpekar @H-Huang @kwen2501

Copy link

pytorch-bot bot commented Sep 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3068

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 219e199 with merge base 3eee4f2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 requested a review from pradeepfn October 15, 2024 18:28
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Thanks for your contribution!

@svekars svekars merged commit 96cdbae into pytorch:main Oct 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Distributed Checkpoint Code Example Is Failing

4 participants