Skip to content

updates for ipex example page #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

updates for ipex example page #3486

merged 1 commit into from
Jul 24, 2025

Conversation

ZailiWang
Copy link
Contributor

Fixes #3421

Description

Removing the deprecated torchscript related example codes, as well as some other code updates.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3486

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e330b30 with merge base 05c058d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@sekyondaMeta sekyondaMeta added the tutorials_audit used on tutorial audit PRs label Jul 23, 2025
@sekyondaMeta
Copy link
Contributor

@Xia-Weiwen Any issues with us merging this update?

sekyondaMeta
sekyondaMeta approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@sekyondaMeta sekyondaMeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xia-Weiwen
Copy link
Contributor

Hi @sekyondaMeta I am afraid we don't have the permission to merge this PR. Does @pytorchbot merge work? Besides, we are considering removing this tutorial. Will come back soon when we reach a conclusion. Thanks.

@sekyondaMeta
Copy link
Contributor

@Xia-Weiwen

I can merge it, just wanted to make sure this was all good on your end. Do you have an idea on when you might know if you are removing the tutorial?

@ZailiWang
Copy link
Contributor Author

Hi @sekyondaMeta we have decided to just keep the doc and updating it with the changes in this PR would be fine. Could you help on merging this? thanks.

@sekyondaMeta sekyondaMeta merged commit 355b7dc into pytorch:main Jul 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sekyondaMeta sekyondaMeta sekyondaMeta approved these changes

Assignees
No one assigned
Labels
cla signed tutorials_audit used on tutorial audit PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyTorch Tutorial Audit - Intel for PyTorch
4 participants
@ZailiWang @sekyondaMeta @Xia-Weiwen @facebook-github-bot