[Codemod][CppQualityCommon] Fix CQS signal performance-unnecessary-value-param in fbcode/pytorch/vision/torchvision/csrc/ops/autograd [B]

Reviewed By: dtolnay

Differential Revision: D75049042

fbshipit-source-id: 7a2082c876564a877e1187b42dbc739d62e3697f

Author: generatedunixname89002005287564

torchvision/csrc/ops/autograd/ps_roi_pool_kernel.cpp

@@ -3,6 +3,8 @@
 #include <torch/autograd.h>
 #include <torch/types.h>
 
+#include <utility>
+
 namespace vision {
 namespace ops {
 
@@ -15,8 +17,8 @@ class PSROIPoolFunction : public torch::autograd::Function<PSROIPoolFunction> {
       const torch::autograd::Variable& input,
       const torch::autograd::Variable& rois,
       double spatial_scale,
-      c10::SymInt pooled_height,
-      c10::SymInt pooled_width) {
+      const c10::SymInt& pooled_height,
+      const c10::SymInt& pooled_width) {
     ctx->saved_data["spatial_scale"] = spatial_scale;
     ctx->saved_data["pooled_height"] = pooled_height;
     ctx->saved_data["pooled_width"] = pooled_width;
@@ -84,12 +86,12 @@ class PSROIPoolBackwardFunction
         rois,
         channel_mapping,
         spatial_scale,
-        pooled_height,
-        pooled_width,
-        batch_size,
-        channels,
-        height,
-        width);
+        std::move(pooled_height),
+        std::move(pooled_width),
+        std::move(batch_size),
+        std::move(channels),
+        std::move(height),
+        std::move(width));
 
     return {grad_in};
   }

torchvision/csrc/ops/autograd/roi_align_kernel.cpp

@@ -3,6 +3,8 @@
 #include <torch/autograd.h>
 #include <torch/types.h>
 
+#include <utility>
+
 namespace vision {
 namespace ops {
 
@@ -15,8 +17,8 @@ class ROIAlignFunction : public torch::autograd::Function<ROIAlignFunction> {
       const torch::autograd::Variable& input,
       const torch::autograd::Variable& rois,
       double spatial_scale,
-      c10::SymInt pooled_height,
-      c10::SymInt pooled_width,
+      const c10::SymInt& pooled_height,
+      const c10::SymInt& pooled_width,
       int64_t sampling_ratio,
       bool aligned) {
     ctx->saved_data["spatial_scale"] = spatial_scale;
@@ -90,12 +92,12 @@ class ROIAlignBackwardFunction
         grad,
         rois,
         spatial_scale,
-        pooled_height,
-        pooled_width,
-        batch_size,
-        channels,
-        height,
-        width,
+        std::move(pooled_height),
+        std::move(pooled_width),
+        std::move(batch_size),
+        std::move(channels),
+        std::move(height),
+        std::move(width),
         sampling_ratio,
         aligned);
     return {result};

torchvision/csrc/ops/autograd/roi_pool_kernel.cpp

@@ -3,6 +3,8 @@
 #include <torch/autograd.h>
 #include <torch/types.h>
 
+#include <utility>
+
 namespace vision {
 namespace ops {
 
@@ -15,8 +17,8 @@ class ROIPoolFunction : public torch::autograd::Function<ROIPoolFunction> {
       const torch::autograd::Variable& input,
       const torch::autograd::Variable& rois,
       double spatial_scale,
-      c10::SymInt pooled_height,
-      c10::SymInt pooled_width) {
+      const c10::SymInt& pooled_height,
+      const c10::SymInt& pooled_width) {
     ctx->saved_data["spatial_scale"] = spatial_scale;
     ctx->saved_data["pooled_height"] = pooled_height;
     ctx->saved_data["pooled_width"] = pooled_width;
@@ -84,12 +86,12 @@ class ROIPoolBackwardFunction
         rois,
         argmax,
         spatial_scale,
-        pooled_height,
-        pooled_width,
-        batch_size,
-        channels,
-        height,
-        width);
+        std::move(pooled_height),
+        std::move(pooled_width),
+        std::move(batch_size),
+        std::move(channels),
+        std::move(height),
+        std::move(width));
 
     return {grad_in};
   }