Skip to content

Commit 7499851

Browse files
authored
remove compability for sys.version < 3.5 (#2037)
1 parent 68fe451 commit 7499851

File tree

6 files changed

+6
-43
lines changed

6 files changed

+6
-43
lines changed

test/test_datasets_utils.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,10 @@
88
import gzip
99
import warnings
1010
from torch._utils_internal import get_file_path_2
11+
from urllib.error import URLError
1112

1213
from common_utils import get_tmp_dir
1314

14-
if sys.version_info < (3,):
15-
from urllib2 import URLError
16-
else:
17-
from urllib.error import URLError
18-
1915

2016
TEST_FILE = get_file_path_2(
2117
os.path.dirname(os.path.abspath(__file__)), 'assets', 'grace_hopper_517x606.jpg')
@@ -62,7 +58,6 @@ def test_download_url_retry_http(self):
6258
warnings.warn(msg, RuntimeWarning)
6359
raise unittest.SkipTest(msg)
6460

65-
@unittest.skipIf(sys.version_info < (3,), "Python2 doesn't raise error")
6661
def test_download_url_dont_exist(self):
6762
with get_tmp_dir() as temp_dir:
6863
url = "http://github.com/pytorch/vision/archive/this_doesnt_exist.zip"
@@ -98,7 +93,6 @@ def test_extract_tar(self):
9893
self.assertEqual(data, 'this is the content')
9994

10095
@unittest.skipIf('win' in sys.platform, 'temporarily disabled on Windows')
101-
@unittest.skipIf(sys.version_info < (3,), "Extracting .tar.xz files is not supported under Python 2.x")
10296
def test_extract_tar_xz(self):
10397
for ext, mode in zip(['.tar.xz'], ['w:xz']):
10498
with get_tmp_dir() as temp_dir:

test/test_io.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,11 @@
66
import torchvision.io as io
77
from torchvision import get_video_backend
88
import unittest
9-
import sys
109
import warnings
10+
from urllib.error import URLError
1111

1212
from common_utils import get_tmp_dir
1313

14-
if sys.version_info < (3,):
15-
from urllib2 import URLError
16-
else:
17-
from urllib.error import URLError
1814

1915
try:
2016
import av

torchvision/datasets/folder.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import os
66
import os.path
7-
import sys
87

98

109
def has_file_allowed_extension(filename, extensions):
@@ -119,11 +118,7 @@ def _find_classes(self, dir):
119118
Ensures:
120119
No class is a subdirectory of another.
121120
"""
122-
if sys.version_info >= (3, 5):
123-
# Faster and available in Python 3.5 and above
124-
classes = [d.name for d in os.scandir(dir) if d.is_dir()]
125-
else:
126-
classes = [d for d in os.listdir(dir) if os.path.isdir(os.path.join(dir, d))]
121+
classes = [d.name for d in os.scandir(dir) if d.is_dir()]
127122
classes.sort()
128123
class_to_idx = {classes[i]: i for i in range(len(classes))}
129124
return classes, class_to_idx

torchvision/datasets/lsun.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,7 @@
44
import os.path
55
import io
66
import string
7-
import sys
8-
9-
if sys.version_info < (3, 3):
10-
from collections import Iterable
11-
else:
12-
from collections.abc import Iterable
13-
7+
from collections.abc import Iterable
148
import pickle
159
from .utils import verify_str_arg, iterable_to_str
1610

torchvision/transforms/functional.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import torch
2-
import sys
32
import math
43
from PIL import Image, ImageOps, ImageEnhance, __version__ as PILLOW_VERSION
54
try:
@@ -9,16 +8,9 @@
98
import numpy as np
109
from numpy import sin, cos, tan
1110
import numbers
12-
import collections
11+
from collections.abc import Sequence, Iterable
1312
import warnings
1413

15-
if sys.version_info < (3, 3):
16-
Sequence = collections.Sequence
17-
Iterable = collections.Iterable
18-
else:
19-
Sequence = collections.abc.Sequence
20-
Iterable = collections.abc.Iterable
21-
2214

2315
def _is_pil_image(img):
2416
if accimage is not None:

torchvision/transforms/transforms.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import torch
22
import math
3-
import sys
43
import random
54
from PIL import Image
65
try:
@@ -10,18 +9,11 @@
109
import numpy as np
1110
import numbers
1211
import types
13-
import collections
12+
from collections.abc import Sequence, Iterable
1413
import warnings
1514

1615
from . import functional as F
1716

18-
if sys.version_info < (3, 3):
19-
Sequence = collections.Sequence
20-
Iterable = collections.Iterable
21-
else:
22-
Sequence = collections.abc.Sequence
23-
Iterable = collections.abc.Iterable
24-
2517

2618
__all__ = ["Compose", "ToTensor", "ToPILImage", "Normalize", "Resize", "Scale", "CenterCrop", "Pad",
2719
"Lambda", "RandomApply", "RandomChoice", "RandomOrder", "RandomCrop", "RandomHorizontalFlip",

0 commit comments

Comments
 (0)