Skip to content

Commit 7798b29

Browse files
NicolasHugfacebook-github-bot
authored andcommitted
[fbsync] fix: forbid bool value from JPEG's quality argument type. (#8995)
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: scotts Differential Revision: D77998643 fbshipit-source-id: 4b5f54c2f888407093de769fd81ddde966bf5207
1 parent 3fe26f8 commit 7798b29

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

test/test_transforms_v2.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6206,6 +6206,11 @@ def test_transform_invalid_quality_error(self, quality):
62066206
with pytest.raises(ValueError, match="quality must be an integer from 1 to 100"):
62076207
transforms.JPEG(quality=quality)
62086208

6209+
@pytest.mark.parametrize("quality", [None, True])
6210+
def test_transform_quality_type_error(self, quality):
6211+
with pytest.raises(TypeError, match="quality"):
6212+
transforms.JPEG(quality=quality)
6213+
62096214

62106215
class TestUtils:
62116216
# TODO: Still need to test has_all, has_any, check_type and get_bouding_boxes

torchvision/transforms/v2/_augment.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,8 @@ class JPEG(Transform):
352352
def __init__(self, quality: Union[int, Sequence[int]]):
353353
super().__init__()
354354
if isinstance(quality, int):
355+
if isinstance(quality, bool):
356+
raise TypeError("quality can't be bool")
355357
quality = [quality, quality]
356358
else:
357359
_check_sequence_input(quality, "quality", req_sizes=(2,))

0 commit comments

Comments
 (0)