[lint][codemod][fbcode/pytorch/vision] Applying CLANGFORMAT formatting

Summary:
Removed `fbcode/pytorch/vision` from the `CLANGFORMAT` opt-outs and applied formatting with:

  hg files fbcode/pytorch/vision | arc lint --take CLANGFORMAT --apply-patches -

Furthermore,
- Added `nolint` to the files mentioned below as it contains improperly imported third-party code

    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/exif.h
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/dgif_lib.c
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/gif_hash.c
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/gif_hash.h
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/gif_lib.h
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/gif_lib_private.h
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/gifalloc.c
    fbcode/pytorch/vision/torchvision/csrc/io/image/cpu/giflib/openbsd-reallocarray.c
    fbcode/pytorch/vision/torchvision/csrc/ops/cpu/deform_conv2d_kernel.cpp
    fbcode/pytorch/vision/torchvision/csrc/ops/cuda/deform_conv2d_kernel.cu

- Added `.clang-format` file to `fbcode/pytorch/vision/` directory to avoid formatting of non c like files.

Note: Contains pre-existing build issues

   $ hg st --change 8e76164795 -n | buck2 uquery 'owner(%s)' - | buck2 build -

Reviewed By: VladimirMakaev

Differential Revision: D65142313

fbshipit-source-id: 4670a1f9c27e1eca41ac337813fc8c5ea255e5c5

Author: Ritvij Saxena

.clang-format

@@ -1,92 +1,5 @@
 ---
-AccessModifierOffset: -1
-AlignAfterOpenBracket: AlwaysBreak
-AlignConsecutiveAssignments: false
-AlignConsecutiveDeclarations: false
-AlignEscapedNewlinesLeft: true
-AlignOperands:   false
-AlignTrailingComments: false
-AllowAllParametersOfDeclarationOnNextLine: false
-AllowShortBlocksOnASingleLine: false
-AllowShortCaseLabelsOnASingleLine: false
-AllowShortFunctionsOnASingleLine: Empty
-AllowShortIfStatementsOnASingleLine: false
-AllowShortLoopsOnASingleLine: false
-AlwaysBreakAfterReturnType: None
-AlwaysBreakBeforeMultilineStrings: true
-AlwaysBreakTemplateDeclarations: true
-BinPackArguments: false
-BinPackParameters: false
-BraceWrapping:
-  AfterClass:      false
-  AfterControlStatement: false
-  AfterEnum:       false
-  AfterFunction:   false
-  AfterNamespace:  false
-  AfterObjCDeclaration: false
-  AfterStruct:     false
-  AfterUnion:      false
-  BeforeCatch:     false
-  BeforeElse:      false
-  IndentBraces:    false
-BreakBeforeBinaryOperators: None
-BreakBeforeBraces: Attach
-BreakBeforeTernaryOperators: true
-BreakConstructorInitializersBeforeComma: false
-BreakAfterJavaFieldAnnotations: false
-BreakStringLiterals: false
-ColumnLimit:     80
-CommentPragmas:  '^ IWYU pragma:'
-#CompactNamespaces: false
-ConstructorInitializerAllOnOneLineOrOnePerLine: true
-ConstructorInitializerIndentWidth: 4
-ContinuationIndentWidth: 4
-Cpp11BracedListStyle: true
-DerivePointerAlignment: false
-DisableFormat:   false
-ForEachMacros:   [ FOR_EACH_RANGE, FOR_EACH, ]
-IncludeCategories:
-  - Regex:           '^<.*\.h(pp)?>'
-    Priority:        1
-  - Regex:           '^<.*'
-    Priority:        2
-  - Regex:           '.*'
-    Priority:        3
-IndentCaseLabels: true
-IndentWidth:     2
-IndentWrappedFunctionNames: false
-KeepEmptyLinesAtTheStartOfBlocks: false
-MacroBlockBegin: ''
-MacroBlockEnd:   ''
-MaxEmptyLinesToKeep: 1
-NamespaceIndentation: None
-PenaltyBreakBeforeFirstCallParameter: 1
-PenaltyBreakComment: 300
-PenaltyBreakFirstLessLess: 120
-PenaltyBreakString: 1000
-PenaltyExcessCharacter: 1000000
-PenaltyReturnTypeOnItsOwnLine: 2000000
-PointerAlignment: Left
-ReflowComments:  true
-SortIncludes:    true
-SpaceAfterCStyleCast: false
-SpaceBeforeAssignmentOperators: true
-SpaceBeforeParens: ControlStatements
-SpaceInEmptyParentheses: false
-SpacesBeforeTrailingComments: 1
-SpacesInAngles:  false
-SpacesInContainerLiterals: true
-SpacesInCStyleCastParentheses: false
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
-Standard:        Cpp11
-TabWidth:        8
-UseTab:          Never
----
 Language: ObjC
-ColumnLimit: 120
-AlignAfterOpenBracket: Align
-ObjCBlockIndentWidth: 2
-ObjCSpaceAfterProperty: false
-ObjCSpaceBeforeProtocolList: false
+DisableFormat: true
+SortIncludes: false
 ...

ios/VisionTestApp/VisionTestApp/AppDelegate.h

@@ -1,7 +1,7 @@
 #import <UIKit/UIKit.h>
 
-@interface AppDelegate : UIResponder <UIApplicationDelegate>
+@interface AppDelegate : UIResponder<UIApplicationDelegate>
 
-@property(strong, nonatomic) UIWindow *window;
+@property(strong, nonatomic) UIWindow* window;
 
 @end

ios/VisionTestApp/VisionTestApp/ModelRunner.h

@@ -5,7 +5,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface ModelRunner : NSObject
 
-+ (NSString* )run;
++ (NSString*)run;
 + (BOOL)setUp;
 
 @end

ios/VisionTestApp/VisionTestApp/ViewController.h

@@ -3,5 +3,4 @@
 
 @interface ViewController : UIViewController
 
-
 @end

test/cpp/test_custom_operators.cpp

@@ -7,7 +7,8 @@
 
 TEST(test_custom_operators, nms) {
   // make sure that the torchvision ops are visible to the jit interpreter
-  auto& ops = torch::jit::getAllOperatorsFor(torch::jit::Symbol::fromQualString("torchvision::nms"));
+  auto& ops = torch::jit::getAllOperatorsFor(
+      torch::jit::Symbol::fromQualString("torchvision::nms"));
   ASSERT_EQ(ops.size(), 1);
 
   auto& op = ops.front();
@@ -24,29 +25,35 @@ TEST(test_custom_operators, nms) {
 
   at::Tensor output = vision::ops::nms(boxes, scores, thresh);
   ASSERT_TRUE(output_jit.allclose(output));
-
 }
 
 TEST(test_custom_operators, roi_align_visible) {
-  // make sure that the torchvision ops are visible to the jit interpreter even if
-  // not explicitly included
-  auto& ops = torch::jit::getAllOperatorsFor(torch::jit::Symbol::fromQualString("torchvision::roi_align"));
+  // make sure that the torchvision ops are visible to the jit interpreter even
+  // if not explicitly included
+  auto& ops = torch::jit::getAllOperatorsFor(
+      torch::jit::Symbol::fromQualString("torchvision::roi_align"));
   ASSERT_EQ(ops.size(), 1);
 
   auto& op = ops.front();
   ASSERT_EQ(op->schema().name(), "torchvision::roi_align");
 
   torch::jit::Stack stack;
-  float roi_data[] = {
-    0., 0., 0., 5., 5.,
-    0., 5., 5., 10., 10.
-  };
-  at::Tensor input = at::rand({1, 2, 10, 10}), rois = at::from_blob(roi_data, {2, 5});
+  float roi_data[] = {0., 0., 0., 5., 5., 0., 5., 5., 10., 10.};
+  at::Tensor input = at::rand({1, 2, 10, 10}),
+             rois = at::from_blob(roi_data, {2, 5});
   double spatial_scale = 1.0;
   int64_t pooled_height = 3, pooled_width = 3, sampling_ratio = -1;
   bool aligned = true;
 
-  torch::jit::push(stack, input, rois, spatial_scale, pooled_height, pooled_width, sampling_ratio, aligned);
+  torch::jit::push(
+      stack,
+      input,
+      rois,
+      spatial_scale,
+      pooled_height,
+      pooled_width,
+      sampling_ratio,
+      aligned);
   op->getOperation()(stack);
   at::Tensor output_jit;
   torch::jit::pop(stack, output_jit);

torchvision/csrc/io/decoder/decoder.cpp

@@ -387,16 +387,21 @@ bool Decoder::init(
   for (unsigned int i = 0; i < inputCtx_->nb_streams; i++) {
     if (
 #if LIBAVUTIL_VERSION_MAJOR < 56 // Before FFMPEG 4.0
-      inputCtx_->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO
+        inputCtx_->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO
 #else // FFMPEG 4.0+
-      inputCtx_->streams[i]->codecpar->codec_type == AVMEDIA_TYPE_VIDEO
+        inputCtx_->streams[i]->codecpar->codec_type == AVMEDIA_TYPE_VIDEO
 #endif
-      && inputCtx_->streams[i]->duration > 0
-    ) {
-      // There is at least two 1/r_frame_rates from the frame before the last one until the video duration,
-      // let's prefer to set duration after the frame before the last one, but as early as possible
-      double correction = 2 * inputCtx_->streams[i]->r_frame_rate.den / (double) inputCtx_->streams[i]->r_frame_rate.num - 1 / (double) AV_TIME_BASE;
-      videoDurationMs_ = 1000 * inputCtx_->streams[i]->duration * inputCtx_->streams[i]->time_base.num / (double) inputCtx_->streams[i]->time_base.den - 1000 * correction;
+        && inputCtx_->streams[i]->duration > 0) {
+      // There is at least two 1/r_frame_rates from the frame before the last
+      // one until the video duration, let's prefer to set duration after the
+      // frame before the last one, but as early as possible
+      double correction = 2 * inputCtx_->streams[i]->r_frame_rate.den /
+              (double)inputCtx_->streams[i]->r_frame_rate.num -
+          1 / (double)AV_TIME_BASE;
+      videoDurationMs_ = 1000 * inputCtx_->streams[i]->duration *
+              inputCtx_->streams[i]->time_base.num /
+              (double)inputCtx_->streams[i]->time_base.den -
+          1000 * correction;
       break;
     }
   }
@@ -568,7 +573,6 @@ int Decoder::getFrame(size_t workingTimeInMs) {
       continue;
     }
 
-
     size_t numConsecutiveNoBytes = 0;
     // it can be only partial decoding of the package bytes
     do {
@@ -614,20 +618,27 @@ int Decoder::getFrame(size_t workingTimeInMs) {
 
     if (params_.uniformSampling > 1) {
       if (doSeek_) {
-        double duration = videoDurationMs_ > 0 ? videoDurationMs_ : params_.expectedDuration;
-        double step = (duration * AV_TIME_BASE) / (1000 * (params_.uniformSampling - 1));
-        avformat_seek_file(inputCtx_, -1, static_cast<int64_t>(step * kFramesDecoded_) + 1, static_cast<int64_t>(step * (kFramesDecoded_ + 1)), static_cast<int64_t>(step * (kFramesDecoded_ + 1)), 0);
+        double duration =
+            videoDurationMs_ > 0 ? videoDurationMs_ : params_.expectedDuration;
+        double step =
+            (duration * AV_TIME_BASE) / (1000 * (params_.uniformSampling - 1));
+        avformat_seek_file(
+            inputCtx_,
+            -1,
+            static_cast<int64_t>(step * kFramesDecoded_) + 1,
+            static_cast<int64_t>(step * (kFramesDecoded_ + 1)),
+            static_cast<int64_t>(step * (kFramesDecoded_ + 1)),
+            0);
         ++kFramesDecoded_;
         doSeek_ = false;
       }
     }
   }
 
   av_packet_free(&avPacket);
-  VLOG(2) << "Interrupted loop"
-          << ", interrupted_ " << interrupted_ << ", inRange_.any() "
-          << inRange_.any() << ", decodedFrame " << decodedFrame << ", result "
-          << result;
+  VLOG(2) << "Interrupted loop" << ", interrupted_ " << interrupted_
+          << ", inRange_.any() " << inRange_.any() << ", decodedFrame "
+          << decodedFrame << ", result " << result;
 
   // loop can be terminated, either by:
   // 1. explicitly interrupted
@@ -691,7 +702,7 @@ int Decoder::processPacket(
       startCondition = msg.header.pts >= params_.startOffset;
     }
     if (endInRange && startCondition) {
-        *hasMsg = pushMsg(std::move(msg));
+      *hasMsg = pushMsg(std::move(msg));
     }
   }
   return result;
@@ -706,9 +717,12 @@ bool Decoder::pushMsg(DecoderOutputMessage&& msg) {
     return true;
   }
 
-  double duration = videoDurationMs_ > 0 ? videoDurationMs_ : params_.expectedDuration;
-  double step = (duration * AV_TIME_BASE) / (1000 * (params_.uniformSampling - 1));
-  if (pastDecodedPTS_ < step * kFramesDecoded_ && step * kFramesDecoded_ <= currentDecodedPTS_) {
+  double duration =
+      videoDurationMs_ > 0 ? videoDurationMs_ : params_.expectedDuration;
+  double step =
+      (duration * AV_TIME_BASE) / (1000 * (params_.uniformSampling - 1));
+  if (pastDecodedPTS_ < step * kFramesDecoded_ &&
+      step * kFramesDecoded_ <= currentDecodedPTS_) {
     push(std::move(msg));
     doSeek_ = true;
     return true;

torchvision/csrc/io/decoder/decoder.h

@@ -77,12 +77,12 @@ class Decoder : public MediaDecoder {
       bool fastSeek = false);
   void flushStreams();
   void cleanUp();
-  bool pushMsg(DecoderOutputMessage&& msg); // returns whether frame is passed to downstream
+  bool pushMsg(DecoderOutputMessage&&
+                   msg); // returns whether frame is passed to downstream
 
  protected:
   DecoderParameters params_;
 
-
  private:
   SeekableBuffer seekableBuffer_;
   int printPrefix{1};

torchvision/csrc/io/decoder/defs.h

@@ -220,7 +220,8 @@ struct DecoderParameters {
   // integer not lesser than 32. It is 5000000 by default.
   int64_t probeSize{5000000};
 
-  // Expected duration of the video to be decoded, mainly used with uniform sampling
+  // Expected duration of the video to be decoded, mainly used with uniform
+  // sampling
   float expectedDuration{0.0f};
 
   // Sample N key-frames from the video roughly uniformly across the timeline

torchvision/csrc/io/decoder/gpu/gpu_decoder.cpp

@@ -46,8 +46,8 @@ void GPUDecoder::seek(double timestamp, bool keyframes_only) {
   demuxer.seek(timestamp, flag);
 }
 
-c10::Dict<std::string, c10::Dict<std::string, double>> GPUDecoder::
-    get_metadata() const {
+c10::Dict<std::string, c10::Dict<std::string, double>>
+GPUDecoder::get_metadata() const {
   c10::Dict<std::string, c10::Dict<std::string, double>> metadata;
   c10::Dict<std::string, double> video_metadata;
   video_metadata.insert("duration", demuxer.get_duration());

torchvision/csrc/io/decoder/sync_decoder_test.cpp

@@ -158,8 +158,7 @@ void runDecoder(SyncDecoder& decoder) {
       AVSubtitle sub;
       memset(&sub, 0, sizeof(sub));
       EXPECT_TRUE(Util::deserialize(*out.payload, &sub));
-      LOG(INFO) << "Found subtitles"
-                << ", num rects: " << sub.num_rects;
+      LOG(INFO) << "Found subtitles" << ", num rects: " << sub.num_rects;
       for (int i = 0; i < sub.num_rects; ++i) {
         std::string text = "picture";
         if (sub.rects[i]->type == SUBTITLE_TEXT) {
@@ -210,9 +209,9 @@ TEST(SyncDecoder, TestSyncDecoderPerformance) {
   auto new8x8 = measurePerformanceUs(stats, kRounds, 8, 8);
   auto new16x8 = measurePerformanceUs(stats, kRounds, 16, 8);
   auto new32x4 = measurePerformanceUs(stats, kRounds, 32, 4);
-  LOG(INFO) << "Clip decoding (us)"
-            << ", new(4x2): " << new4x2 << ", new(8x8): " << new8x8
-            << ", new(16x8): " << new16x8 << ", new(32x4): " << new32x4;
+  LOG(INFO) << "Clip decoding (us)" << ", new(4x2): " << new4x2
+            << ", new(8x8): " << new8x8 << ", new(16x8): " << new16x8
+            << ", new(32x4): " << new32x4;
 }
 
 TEST(SyncDecoder, Test) {