Put back clang formatting, via pre-commit this time (#9160)

Author: NicolasHug

.github/scripts/run-clang-format.py

@@ -40,36 +40,6 @@ jobs:
           exit 1
         fi
 
-  # c-source:
-  #   uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
-  #   permissions:
-  #     id-token: write
-  #     contents: read
-  #   with:
-  #     repository: pytorch/vision
-  #     test-infra-ref: main
-  #     script: |
-  #       set -euo pipefail
-
-  #       echo '::group::Setup environment'
-  #       CONDA_PATH=$(which conda)
-  #       eval "$(${CONDA_PATH} shell.bash hook)"
-  #       conda create --name ci --quiet --yes -c conda-forge python=3.9 clang-format
-  #       conda activate ci
-  #       echo '::endgroup::'
-
-
-  #       echo '::group::Lint C source'
-  #       set +e
-  #       ./.github/scripts/run-clang-format.py -r torchvision/csrc --exclude "torchvision/csrc/io/image/cpu/giflib/*"
-
-  #       if [ $? -ne 0 ]; then
-  #         git --no-pager diff
-  #         exit 1
-  #       fi
-  #       echo '::endgroup::'
-
-
   python-types:
     uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
     permissions:

.github/workflows/lint.yml

@@ -30,3 +30,12 @@ repos:
     rev: 6.1.1
     hooks:
       - id: pydocstyle
+
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v18.1.3
+    hooks:
+      - id: clang-format
+        name: clang-format
+        files: \.(cpp|hpp|c|h|cu)$
+        types: [file]
+        exclude: ^torchvision/csrc/io/image/cpu/giflib/

.pre-commit-config.yaml

@@ -46,8 +46,8 @@ void GPUDecoder::seek(double timestamp, bool keyframes_only) {
   demuxer.seek(timestamp, flag);
 }
 
-c10::Dict<std::string, c10::Dict<std::string, double>>
-GPUDecoder::get_metadata() const {
+c10::Dict<std::string, c10::Dict<std::string, double>> GPUDecoder::
+    get_metadata() const {
   c10::Dict<std::string, c10::Dict<std::string, double>> metadata;
   c10::Dict<std::string, double> video_metadata;
   video_metadata.insert("duration", demuxer.get_duration());