🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9171

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 4bffd1e with merge base 97920a5 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pixels outside the image boundary is a really nice way of putting it, props on that!

On that note though, please be careful with a few things about the change. Mainly, you've also altered the Pad and RandomCrop docstrings, and I think it's important on those two to keep the padding_mode reference given that the fill parameter is only useful when the other one is set to "constant". Both reverting the change or putting [...] for pixels outside the image boundary when the ``padding_mode`` is constant should be fine!

Also I think there's a misindentation on the RandomAffine docstring and an extra line in RandomCrop, please be on the lookout for that kind of stuff :)

pixels outside the image boundary is a really nice way of putting it, props on that!

On that note though, please be careful with a few things about the change. Mainly, you've also altered the Pad and RandomCrop docstrings, and I think it's important on those two to keep the padding_mode reference given that the fill parameter is only useful when the other one is set to "constant". Both reverting the change or putting [...] for pixels outside the image boundary when thepadding_modeis constant should be fine!

Also I think there's a misindentation on the RandomAffine docstring and an extra line in RandomCrop, please be on the lookout for that kind of stuff :)

I will keep that in mind and update the PR.

Agreed with @diaz-esparza that we need to make sure that when there is a padding_mode parameter, we explicitly mention it in the docstring.

I will work on it.