Skip to content

Commit c03f6aa

Browse files
authored
Remove fmtlib explicit dependency. (#9702)
This PR removes the temporary fmtlib dependency introduced in #9650 (see issue #9653). As explained [in this comment][1], the dependency was only added to work around a build issue that should have been fixed upstream in PyTorch. Before the `fmtlib` version bump to 12 in PyTorch (pytorch/pytorch#163441), `fmtlib` headers were exported by default. After the bump, they stopped being exported, which caused the issue. That behavior has since been fixed in PyTorch (pytorch/pytorch#164139), so we can safely remove the explicit fmtlib dependency. [1]: #9650 (review)
1 parent d0b43cc commit c03f6aa

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

WORKSPACE

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ new_local_repository(
4242
path = PYTORCH_LOCAL_DIR,
4343
)
4444

45-
new_local_repository(
46-
name = "fmt",
47-
build_file = "//bazel:fmt.BUILD",
48-
path = PYTORCH_LOCAL_DIR + "/third_party/fmt",
49-
)
50-
5145
############################# OpenXLA Setup ###############################
5246

5347
# To build PyTorch/XLA with a new revison of OpenXLA, update the xla_hash to

bazel/fmt.BUILD

Lines changed: 0 additions & 9 deletions
This file was deleted.

bazel/torch.BUILD

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ cc_library(
1010
["torch/include/**/*.h"],
1111
["torch/include/google/protobuf/**/*.h"],
1212
),
13-
deps = [
14-
"@fmt",
15-
],
1613
strip_include_prefix = "torch/include",
1714
)
1815

0 commit comments

Comments
 (0)