fix: drop FF for MDM authd cases (#838)

MDM doesn't support yet FF, this change unblocks the commands when CLI is using machine tokens.

Author: yeisonvargasf

safety/auth/utils.py

@@ -167,28 +167,38 @@ def initialize(ctx: Any, refresh: bool = True) -> None:
     if not ctx.obj:
         ctx.obj = SafetyCLI()
 
-    for feature in FeatureType:
-        value = get_config_setting(feature.name)
-        if value is not None:
-            current_values[feature] = str_to_bool(value)
-
-    if refresh:
-        try:
-            settings = ctx.obj.auth.platform.initialize()  # type: ignore
-        except Exception:
-            LOG.info("Unable to initialize, continue with default values.")
+    has_machine_token = (
+        ctx.obj.auth
+        and ctx.obj.auth.platform
+        and ctx.obj.auth.platform.has_machine_token
+    )
 
-    if settings:
+    if not has_machine_token:
+        for feature in FeatureType:
+            value = get_config_setting(feature.name)
+            if value is not None:
+                current_values[feature] = str_to_bool(value)
+
+        if refresh:
+            try:
+                settings = ctx.obj.auth.platform.initialize()  # type: ignore
+            except Exception:
+                LOG.info("Unable to initialize, continue with default values.")
+
+        if settings:
+            for feature in FeatureType:
+                server_value = str_to_bool(settings.get(feature.config_key))
+                if server_value is not None:
+                    if (
+                        feature not in current_values
+                        or current_values[feature] != server_value
+                    ):
+                        current_values[feature] = server_value
+
+            save_flags_config(current_values)
+    else:
         for feature in FeatureType:
-            server_value = str_to_bool(settings.get(feature.config_key))
-            if server_value is not None:
-                if (
-                    feature not in current_values
-                    or current_values[feature] != server_value
-                ):
-                    current_values[feature] = server_value
-
-        save_flags_config(current_values)
+            current_values[feature] = True
 
     for feature, value in current_values.items():
         if value is not None:

safety/system_scan/command.py

@@ -16,10 +16,12 @@
     get_command_for,
     pass_safety_cli_obj,
     CommandType,
+    FeatureType,
 )
 from safety.constants import (
     DEFAULT_EPILOG,
     CONTEXT_COMMAND_TYPE,
+    CONTEXT_FEATURE_TYPE,
     EXIT_CODE_INVALID_AUTH_CREDENTIAL,
     get_required_config_setting,
 )
@@ -52,7 +54,7 @@
         "allow_extra_args": True,
         "ignore_unknown_options": True,
         CONTEXT_COMMAND_TYPE: CommandType.BETA,
-        # CONTEXT_FEATURE_TYPE: FeatureType.PLATFORM,  TODO: We're disabling this until we have feature flags working with the new MDM auth
+        CONTEXT_FEATURE_TYPE: FeatureType.PLATFORM,
     },
 )
 @pass_safety_cli_obj

tests/auth/test_auth_utils.py

@@ -40,6 +40,7 @@ def test_initialize_with_no_session(
         mock_initialize = Mock(side_effect=InvalidCredentialError())
         mock_client = Mock()
         mock_client.initialize = mock_initialize
+        mock_client.has_machine_token = False
         mock_auth = Mock()
         mock_auth.platform = mock_client
         mock_safety_cli.auth = mock_auth
@@ -68,6 +69,7 @@ def test_initialize_without_refresh(
             patch("safety.auth.utils.setattr") as mock_setattr,
         ):
             mock_safety_cli = MockSafetyCLI.return_value
+            mock_safety_cli.auth.platform.has_machine_token = False
 
             initialize(ctx, refresh=False)
 
@@ -111,6 +113,7 @@ def test_initialize_with_server_response(
         )
         mock_client = Mock()
         mock_client.initialize = mock_initialize
+        mock_client.has_machine_token = False
         mock_auth = Mock()
         mock_auth.platform = mock_client
         mock_safety_cli.auth = mock_auth