Renamed validate_settings to validate_configuration, renamed create_or_get_venv to get_or_create_venv

Author: mikicz

arca/backend/base.py

@@ -43,9 +43,9 @@ def inject_arca(self, arca):
         """
         self._arca = arca
 
-        self.validate_settings()
+        self.validate_configuration()
 
-    def validate_settings(self):
+    def validate_configuration(self):
         pass
 
     @cached_property

arca/backend/docker.py

@@ -79,7 +79,7 @@ def __init__(self, **kwargs):
         self._containers = set()
         self.client = None
 
-    def validate_settings(self):
+    def validate_configuration(self):
         """
         Validates the provided settings.
 
@@ -89,7 +89,7 @@ def validate_settings(self):
 
         :raise ArcaMisconfigured: If some of the settings aren't valid.
         """
-        super().validate_settings()
+        super().validate_configuration()
 
         if self.inherit_image is not None:
             try:

arca/backend/vagrant.py

@@ -83,14 +83,14 @@ def inject_arca(self, arca):
 
         self.log_cm = vagrant.make_file_cm(self.log_path)
 
-    def validate_settings(self):
-        """ Runs :meth:`arca.DockerBackend.validate_settings` and checks extra:
+    def validate_configuration(self):
+        """ Runs :meth:`arca.DockerBackend.validate_configuration` and checks extra:
 
         * ``box`` format
         * ``provider`` format
         * ``use_registry_name`` is set and ``registry_pull_only`` is not enabled.
         """
-        super().validate_settings()
+        super().validate_configuration()
 
         if self.use_registry_name is None:
             raise ArcaMisconfigured("Use registry name setting is required for VagrantBackend")

arca/backend/venv.py

@@ -25,7 +25,7 @@ def get_virtualenv_name(self, requirements_file: Path) -> str:
 
         Either:
 
-        * SHA1 of the requirements file and Arca version
+        * hash of the requirements file and Arca version
         * ``no_requirements_file`` if the requirements file doesn't exist.
 
         :param requirements_file: :class:`Path <pathlib.Path>` to where the requirements file
@@ -37,7 +37,7 @@ def get_virtualenv_name(self, requirements_file: Path) -> str:
         else:
             return self.get_requirements_hash(requirements_file)
 
-    def create_or_get_venv(self, path: Path) -> Path:
+    def get_or_create_venv(self, path: Path) -> Path:
         """
         Gets the name of the virtualenv from :meth:`get_virtualenv_name`, checks if it exists already,
         creates it and installs requirements otherwise. The virtualenvs are stored in a folder based
@@ -46,9 +46,9 @@ def create_or_get_venv(self, path: Path) -> Path:
         :param path: :class:`Path <pathlib.Path>` to the cloned repository.
         """
         requirements_file = self.get_requirements_file(path)
-        requirements_name = self.get_virtualenv_name(requirements_file)
+        venv_name = self.get_virtualenv_name(requirements_file)
 
-        venv_path = Path(self._arca.base_dir) / "venvs" / requirements_name
+        venv_path = Path(self._arca.base_dir) / "venvs" / venv_name
 
         if not venv_path.exists():
             logger.info(f"Creating a venv in {venv_path}")
@@ -91,4 +91,4 @@ def create_or_get_venv(self, path: Path) -> Path:
     def get_or_create_environment(self, repo: str, branch: str, git_repo: Repo, repo_path: Path) -> str:
         """ Handles the requirements in the target repository, returns a path to a executable of the virtualenv.
         """
-        return str(self.create_or_get_venv(repo_path).resolve() / "bin" / "python")
+        return str(self.get_or_create_venv(repo_path).resolve() / "bin" / "python")