Skip to content

Commit bda9390

Browse files
committed
Changed the tags so arca and python versions are included
1 parent a355605 commit bda9390

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

arca/backend/docker.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,7 @@ def get_image_name(self, requirements_file: Optional[Path], dependencies: Option
163163
""" Returns the name for images with installed requirements and dependencies.
164164
"""
165165
if self.inherit_image is None:
166-
return "arca_{arca_version}_{python_version}".format(
167-
arca_version=str(arca.__version__),
168-
python_version=self.get_python_version()
169-
)
166+
return self.get_arca_base_name()
170167
else:
171168
name, tag = str(self.inherit_image).split(":")
172169

@@ -209,13 +206,20 @@ def get_image_tag(self, requirements_file: Optional[Path], dependencies: Optiona
209206
210207
* From Arca base image:
211208
212-
* `ase` – no requirements and no dependencies
213-
* `asd_<hash(dependencies)>` – only dependencies
214-
* `are_<hash(requirements)>` – only requirements
215-
* `ard_<hash(hash(dependencies) + hash(requirements))>` – both requirements and dependencies
209+
* `<Arca version>_<Python version>_ase` – no requirements and no dependencies
210+
* `<Arca version>_<Python version>_asd_<hash(dependencies)>` – only dependencies
211+
* `<Arca version>_<Python version>_are_<hash(requirements)>` – only requirements
212+
* `<Arca version>_<Python version>_ard_<hash(hash(dependencies) + hash(requirements))>`
213+
– both requirements and dependencies
214+
216215
"""
217216

218-
prefix = "i" if self.inherit_image is not None else "a"
217+
prefix = ""
218+
219+
if self.inherit_image is None:
220+
prefix = "{}_{}_".format(arca.__version__, self.get_python_version())
221+
222+
prefix += "i" if self.inherit_image is not None else "a"
219223
prefix += "r" if requirements_file is not None else "s"
220224
prefix += "d" if dependencies is not None else "e"
221225

0 commit comments

Comments
 (0)