Skip to content

Commit e085e00

Browse files
committed
Don't show iCal link for courses without start/end times
Full-day events don't show up well in the iCal export. That would be nice to fix, but for now, let's just not show them.
1 parent 186070c commit e085e00

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

naucse/routes.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,12 @@ def course_calendar_ics(course):
333333
if not course.start_date:
334334
abort(404)
335335
calendar = ics.Calendar()
336-
for session in course.sessions.values():
336+
for session in course.sessions.values():
337337
if session.start_time:
338338
start_time = session.start_time
339339
end_time = session.end_time
340340
else:
341-
start_time = datetime.datetime.combine(session.date, datetime.time())
342-
end_time = None
341+
abort(404)
343342
cal_event = ics.Event(
344343
name = session.title,
345344
begin = start_time,

naucse/templates/course_calendar.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,14 @@ <h1>{{ course.title }}</h1>
2828
{% if course.subtitle is defined and course.subtitle != None %}
2929
<h2>{{ course.subtitle }}</h2>
3030
{% endif%}
31-
<div>
32-
Přidej si kurz do svého kalendáře:
33-
<a href="{{ url_for('course_calendar_ics', course=course) }}">iCal</a>
34-
</div>
31+
{% if course.default_start_time %}
32+
<div>
33+
Přidej si kurz do svého kalendáře:
34+
<a href="{{ url_for('course_calendar_ics', course=course) }}">iCal</a>
35+
</div>
36+
{% else %}
37+
<!-- iCal link missing because course doesn't have info about start/end times. -->
38+
{% endif%}
3539
{% if course.start_date %}
3640
{% for year, month in months %}
3741
<h3 class="calendar-heading">

0 commit comments

Comments
 (0)