abi3 compatible wheels (#109)

* make wheels abi3 compatible for linux

* nanobind supports 3.12+

* fix wheel ABI build

* add abi3 testing

* fix wheel testing

* correctly extract deps

* add missing script

* simply deps install

* use -r

* use uv

* skip due to cross-path

* use build[uv]

* don't use build[uv]

* don't install uv

Author: akaszynski

.github/workflows/build-and-deploy.yml

@@ -32,6 +32,41 @@ jobs:
         name: tetgen-wheels-${{ matrix.os }}
         path: ./wheelhouse/*.whl
 
+  test_abi3:
+    name: Test ABI3 wheels
+    needs: build_wheels
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ['3.13'] # , '3.14']  # skip 3.14 testing until vtk 9.6 is released
+        os: [ubuntu-24.04, windows-2025, macos-latest, macos-15-intel, ubuntu-24.04-arm]
+    steps:
+    - uses: actions/checkout@v6
+    - uses: actions/setup-python@v6
+      with:
+        python-version: ${{ matrix.python-version }}
+    - uses: actions/download-artifact@v7
+      with:
+        pattern: tetgen-wheels-${{ matrix.os }}
+        path: wheels/
+    - name: Find ABI3 wheel
+      id: find_wheel
+      shell: bash
+      run: |
+        WHEEL=$(ls wheels/*abi3*.whl | head -n 1)
+        echo "wheel=$WHEEL" >> "$GITHUB_OUTPUT"
+    - name: Install wheel
+      run: pip install "${{ steps.find_wheel.outputs.wheel }}"
+    - name: Install test dependencies from source
+      run: |
+        pip install tomli
+        python tools/extract-deps.py
+        pip install -r requirements-tests.txt
+    - name: Run tests
+      run: pytest
+
+
   build_sdist:
     name: Build source distribution
     runs-on: ubuntu-latest

pyproject.toml

@@ -23,7 +23,7 @@ dependencies = [
 description = "Python interface to tetgen"
 name = "tetgen"
 readme = "README.rst"
-requires-python = ">=3.10"
+requires-python = ">=3.10,<3.15"
 version = "0.9.dev0"
 
 [project.optional-dependencies]
@@ -61,11 +61,18 @@ Homepage = 'https://github.com/pyvista/tetgen'
 
 [tool.cibuildwheel]
 archs = ["auto64"]  # 64-bit only
-build = "cp310-* cp311-* cp312-* cp313-*"  # " cp314*"  # skip 3.14 until vtk 9.6 is released
-skip = " cp314t-* *musllinux*"  # disable musl-based wheels and free threading
+before-build = "pip install abi3audit"
+build = "cp310-* cp311-* cp312-*"  # 3.12+ are abi3 wheels
+skip = "*musllinux*"
 test-command = "pytest {project}/tests -vv"
 test-requires = "pytest pyvista meshio pymeshfix"
 
+[tool.cibuildwheel.linux]
+repair-wheel-command = [
+  "auditwheel repair -w {dest_dir} {wheel}",
+  "bash tools/audit_wheel.sh {wheel}"
+]
+
 [tool.cibuildwheel.macos]
 archs = ["native"]
 
@@ -83,3 +90,6 @@ junit_family = "legacy"
 [tool.ruff]
 indent-width = 4
 line-length = 99
+
+[tool.scikit-build]
+wheel.py-api = "cp312"

src/tetgen/pytetgen.py

@@ -23,7 +23,7 @@
 MTR_POINTDATA_KEY = "target_size"
 
 invalid_input = TypeError(
-    "Invalid input. First argument must be either a pyvista.PolyData object or vertex array, followed by a face arrays and optionally a face marker array."
+    "Invalid input. First argument must be either a pyvista.PolyData object or a vertex array and a face array and optionally a face marker array."
 )
 
 
@@ -193,22 +193,22 @@ def store_mesh(mesh: "PolyData") -> None:
             faces = mesh._connectivity_array.reshape(-1, 3).astype(np.int32, copy=False)
             self._tetgen.load_mesh(points, faces)
 
-        if "PolyData" in str(type(arg0)):  # check without importing
-            from pyvista.core.pointset import PolyData
-
-            if not isinstance(arg0, PolyData):
-                raise TypeError(f"Unknown type {type(arg0)}. Expected a `pyvista.PolyData`.")
-            mesh: PolyData = arg0
-
-            store_mesh(mesh)
-        elif isinstance(arg0, (np.ndarray, list)):
+        if isinstance(arg0, (np.ndarray, list)):
             points = np.asarray(arg0, dtype=np.float64)
             if isinstance(arg1, (np.ndarray, list)) and isinstance(arg2, (np.ndarray, list)):
                 self._load_arrays(points, arg1, arg2)
             elif isinstance(arg1, (np.ndarray, list)):
                 self._load_arrays(points, arg1)
             else:
                 raise invalid_input
+        elif "PolyData" in str(type(arg0)):  # check without importing
+            from pyvista.core.pointset import PolyData
+
+            if not isinstance(arg0, PolyData):
+                raise TypeError(f"Unknown type {type(arg0)}. Expected a `pyvista.PolyData`.")
+            mesh: PolyData = arg0
+
+            store_mesh(mesh)
         elif isinstance(arg0, (str, Path)):
             try:
                 import pyvista.core as pv

tests/test_tetgen.py

@@ -1,4 +1,5 @@
 import os
+import sys
 
 import numpy as np
 import pytest
@@ -73,6 +74,9 @@ def test_attributes() -> None:
     assert isinstance(tet.edges, np.ndarray)
 
 
+@pytest.mark.skipif(
+    sys.platform.startswith("win"), reason="Skip on Windows due to cross-drive relpath issue"
+)
 def test_numpy_tetrahedralize(tmpdir):
     v = np.array(
         [

tools/audit_wheel.sh

@@ -0,0 +1,9 @@
+#!/bin/bash -eo pipefail
+set -x
+
+PY_MINOR=$(python -c "import sys; print(sys.version_info.minor)")
+if [ "$PY_MINOR" -lt 12 ]; then
+  echo "Not checking abi3audit for Python $PY_MINOR < 3.12"
+  exit 0
+fi
+abi3audit --strict --report --verbose "$1"

tools/extract-deps.py

@@ -0,0 +1,8 @@
+"""Create a requirements_testing.txt file directly from a pyproject.toml."""
+
+import tomli
+
+data = tomli.load(open("pyproject.toml", "rb"))
+deps = data["project"]["optional-dependencies"]["tests"]
+with open("requirements-tests.txt", "w") as f:
+    f.write("\n".join(deps))