This closes #2240, fix GetCellValue returning shared string index for empty strings (#2252)

olivere · web-flow · commit 2dcfb6085068 · 2026-01-24T13:12:20.000+08:00
- Fix a v2.10.0 regression bug introduced by commit a33bd1a
diff --git a/rows.go b/rows.go
@@ -355,7 +355,7 @@ func (f *File) getFromStringItem(index int) string {
 			return strconv.Itoa(index)
 		}
 		offsetRange := f.sharedStringItem[index]
-		if len(offsetRange) != 2 || offsetRange[0] >= offsetRange[1] {
+		if len(offsetRange) != 2 || offsetRange[0] > offsetRange[1] {
 			return strconv.Itoa(index)
 		}
 		buf := make([]byte, offsetRange[1]-offsetRange[0])

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ func (f *File) getFromStringItem(index int) string {`
`355`	`355`	`return strconv.Itoa(index)`
`356`	`356`	`}`
`357`	`357`	`offsetRange := f.sharedStringItem[index]`
`358`		`- if len(offsetRange) != 2 \|\| offsetRange[0] >= offsetRange[1] {`
	`358`	`+ if len(offsetRange) != 2 \|\| offsetRange[0] > offsetRange[1] {`
`359`	`359`	`return strconv.Itoa(index)`
`360`	`360`	`}`
`361`	`361`	`buf := make([]byte, offsetRange[1]-offsetRange[0])`