This closes #1298, fix doc properties missing after creating new worksheet

xuri · web-flow · commit 504d469d3da3 · 2022-08-03T00:42:16.000+08:00
diff --git a/sheet.go b/sheet.go
@@ -53,8 +53,6 @@ func (f *File) NewSheet(sheet string) int {
 		}
 	}
 	sheetID++
-	// Update docProps/app.xml
-	f.setAppXML()
 	// Update [Content_Types].xml
 	f.setContentTypes("/xl/worksheets/sheet"+strconv.Itoa(sheetID)+".xml", ContentTypeSpreadSheetMLWorksheet)
 	// Create new sheet /xl/worksheets/sheet%d.xml
@@ -239,11 +237,6 @@ func (f *File) relsWriter() {
 	})
 }
 
-// setAppXML update docProps/app.xml file of XML.
-func (f *File) setAppXML() {
-	f.saveFileList(defaultXMLPathDocPropsApp, []byte(templateDocpropsApp))
-}
-
 // replaceRelationshipsBytes; Some tools that read spreadsheet files have very
 // strict requirements about the structure of the input XML. This function is
 // a horrible hack to fix that after the XML marshalling is completed.

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,6 @@ func (f *File) NewSheet(sheet string) int {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`	`sheetID++`
`56`		`- // Update docProps/app.xml`
`57`		`- f.setAppXML()`
`58`	`56`	`// Update [Content_Types].xml`
`59`	`57`	`f.setContentTypes("/xl/worksheets/sheet"+strconv.Itoa(sheetID)+".xml", ContentTypeSpreadSheetMLWorksheet)`
`60`	`58`	`// Create new sheet /xl/worksheets/sheet%d.xml`
`@@ -239,11 +237,6 @@ func (f *File) relsWriter() {`
`239`	`237`	`})`
`240`	`238`	`}`
`241`	`239`
`242`		`-// setAppXML update docProps/app.xml file of XML.`
`243`		`-func (f *File) setAppXML() {`
`244`		`- f.saveFileList(defaultXMLPathDocPropsApp, []byte(templateDocpropsApp))`
`245`		`-}`
`246`		`-`
`247`	`240`	`// replaceRelationshipsBytes; Some tools that read spreadsheet files have very`
`248`	`241`	`// strict requirements about the structure of the input XML. This function is`
`249`	`242`	`// a horrible hack to fix that after the XML marshalling is completed.`