Skip to content

#2139 avoid lookupLinearSearch malloc slice #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#2139 avoid lookupLinearSearch malloc slice #2140

wants to merge 2 commits into from

Conversation

zhuzhengyang
Copy link

PR Details

avoid lookupLinearSearch malloc slice

Related Issue

#2139

Motivation and Context

How Has This Been Tested

go test -v . -run=TestCalcCellValue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.22%. Comparing base (bb1105b) to head (999a96f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
calc.go 90.38% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   99.23%   99.22%   -0.02%     
==========================================
  Files          32       32              
  Lines       30303    30342      +39     
==========================================
+ Hits        30072    30106      +34     
- Misses        153      157       +4     
- Partials       78       79       +1
Flag Coverage Δ
unittests 99.22% <90.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xuri
xuri requested changes May 21, 2025
View reviewed changes
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Please add unit test cover the changes.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2025
This related with qax-os#2140, alcMatchMatrix function, the parameter…
999a96f 
… matchType is only passed values of 1 and -1 from above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuri xuri xuri requested changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuzhengyang @xuri