Skip to content

This closes #2157, add support parsing rdrichvaluestructure.xml #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

This closes #2157, add support parsing rdrichvaluestructure.xml #2162

wants to merge 2 commits into from

Conversation

shcabin
Copy link
Contributor

@shcabin shcabin commented Jun 22, 2025 •
edited
Loading

PR Details

Description

Prioritize parsing the rvData value definition from rdrichvaluestructure.xml

Related Issue

#2157

Motivation and Context

How Has This Been Tested

run go test locally, and create multiple types of image in cells using Microsoft 365.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shcabin shcabin changed the title [WIP] This closes #2157, add support parsing rdrichvaluestructure.xml This closes #2157, add support parsing rdrichvaluestructure.xml Jun 22, 2025
@shcabin shcabin marked this pull request as ready for review June 23, 2025 13:36
@shcabin shcabin closed this Jun 23, 2025
@shcabin shcabin reopened this Jun 23, 2025
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (845a274) to head (2e726b4).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2162   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          32       32           
  Lines       30574    30603   +29     
=======================================
+ Hits        30343    30372   +29     
  Misses        153      153           
  Partials       78       78
Flag Coverage Δ
unittests 99.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shcabin shcabin force-pushed the feat/support_alt_text branch from 19da10f to e0b65db Compare July 12, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shcabin @xuri