feat: unification of category keys in WebAPI

This PR introduces two new keys for maindata response namely
downloadPath and downloadPathEnabled.

in editCategory/createCategory we take these keys to set category
download_path but while returning the in maindata response we are
sending download_path and this fails for type strict application as
this same key return false or path based on if the download_path is
enabled or not.

leaving the download_path as is as there might be applications which
consume the download_path. (can remove if needed)

closes #23780

Author: jagadam97

src/webui/api/synccontroller.cpp

@@ -604,6 +604,20 @@ void SyncController::makeMaindataSnapshot()
         QJsonObject category = categoryOptions.toJSON();
         // adjust it to be compatible with existing WebAPI
         category[u"savePath"_s] = category.take(u"save_path"_s);
+        // As editCategory/createCategory use downloadPathEnabled and downlaodPath as parameter to set the value
+        // maindata should return the same keys in category section.
+        QJsonValue downloadPathVal = category.value(u"download_path"_s);
+        if (downloadPathVal.isString() && !downloadPathVal.toString().isEmpty())
+        {
+            category[u"downloadPathEnabled"_s] = true;
+            category[u"downloadPath"_s] = downloadPathVal.toString();
+        }
+        else
+        {
+            category[u"downloadPathEnabled"_s] = false;
+            category[u"downloadPath"_s] = QJsonValue::Null;
+        }
+
         category.insert(u"name"_s, categoryName);
         m_maindataSnapshot.categories[categoryName] = category.toVariantMap();
     }
@@ -657,6 +671,19 @@ QJsonObject SyncController::generateMaindataSyncData(const int id, const bool fu
         // adjust it to be compatible with existing WebAPI
         category[u"savePath"_s] = category.take(u"save_path"_s);
         category.insert(u"name"_s, categoryName);
+        // As editCategory/createCategory use downloadPathEnabled and downlaodPath as parameter to set the value
+        // maindata should return the same keys in category section.
+        QVariant downloadPathVal = category.value(u"download_path"_s);
+        if ((downloadPathVal.typeId() == QMetaType::QString) && !downloadPathVal.toString().isEmpty())
+        {
+            category[u"downloadPathEnabled"_s] = true;
+            category[u"downloadPath"_s] = downloadPathVal.toString();
+        }
+        else
+        {
+            category[u"downloadPathEnabled"_s] = false;
+            category[u"downloadPath"_s] = QVariant();
+        }
 
         auto &categorySnapshot = m_maindataSnapshot.categories[categoryName];
         if (const QVariantMap syncData = processMap(categorySnapshot, category); !syncData.isEmpty())