Skip to content

Commit ef3eb90

Browse files
sarutakHyukjinKwon
authored andcommitted
[SPARK-36276][BUILD][FOLLOWUP] Match the version of SBT's checkstyle plugin to Maven's one
### What changes were proposed in this pull request? This PR upgrade SBT's checkstyle plugin to `8.43`. ### Why are the changes needed? The previous PR (apache#33500) upgraded Maven's plugin but seems to have forgot to do for SBT's one. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CIs. Closes apache#34295 from sarutak/upgrade-checkstyle-plugin-to-8.43-for-sbt. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
1 parent 722ac1b commit ef3eb90

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3152,6 +3152,10 @@
31523152
</configuration>
31533153
<dependencies>
31543154
<dependency>
3155+
<!--
3156+
If you are changing the dependency setting for checkstyle plugin,
3157+
please check project/plugins.sbt too.
3158+
-->
31553159
<groupId>com.puppycrawl.tools</groupId>
31563160
<artifactId>checkstyle</artifactId>
31573161
<version>8.43</version>

project/plugins.sbt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
addSbtPlugin("com.etsy" % "sbt-checkstyle-plugin" % "3.1.1")
1919

2020
// sbt-checkstyle-plugin uses an old version of checkstyle. Match it to Maven's.
21-
libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "8.39"
21+
// If you are changing the dependency setting for checkstyle plugin,
22+
// please check pom.xml in the root of the source tree too.
23+
libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "8.43"
2224

2325
// checkstyle uses guava 23.0.
2426
libraryDependencies += "com.google.guava" % "guava" % "23.0"

0 commit comments

Comments
 (0)