Handle arrays of strings in from_qbxml #11

Author: JasonBarnabe

lib/qbxml/hash.rb

@@ -87,9 +87,12 @@ def self.xml_to_hash(node, hash = {}, opts = {})
 
     # Insert node hash into parent hash correctly.
     case hash[name]
-    when Array then hash[name] << node_hash
-    when Hash  then hash[name] = [hash[name], node_hash]
-    else hash[name] = node_hash
+      when Array
+        hash[name] << node_hash
+      when Hash, String
+        hash[name] = [hash[name], node_hash]
+      else
+        hash[name] = node_hash
     end
 
     # Handle child elements
@@ -112,12 +115,14 @@ def self.xml_to_hash(node, hash = {}, opts = {})
       node_hash.delete(CONTENT_ROOT)
     elsif node_hash[CONTENT_ROOT].present?
       node_hash.delete(ATTR_ROOT)
-      hash[name] = \
-        if schema
-          typecast(schema, node.path, node_hash[CONTENT_ROOT], opts[:typecast_cache])
-        else
-          node_hash[CONTENT_ROOT]
-        end
+      v = schema ? typecast(schema, node.path, node_hash[CONTENT_ROOT], opts[:typecast_cache]) : node_hash[CONTENT_ROOT]
+      # We only updated the last element
+      if hash[name].is_a?(Array)
+        hash[name].pop
+        hash[name] << v
+      else
+        hash[name] = v
+      end
     else
       hash[name] = node_hash[CONTENT_ROOT]
     end

test/unit/xml_to_hash_test.rb

@@ -9,5 +9,22 @@ def test_xml_to_hash
     assert_equal h, qbxml.from_qbxml("<?qbxml version=\"7.0\"?>\n<QBXML>\n  <QBXMLMsgsRq>\n    <CustomerQueryRq>\n      <ListID>GUID-GOES-HERE</ListID>\n    </CustomerQueryRq>\n  </QBXMLMsgsRq>\n</QBXML>\n")
   end
 
+  def test_array_of_strings
+    qbxml = Qbxml.new
+    h = {
+      "qbxml" => {
+        "xml_attributes" => {},
+        "qbxml_msgs_rq" => {
+          "xml_attributes" => {},
+          'invoice_query_rq' => {
+            "xml_attributes" => {},
+            'include_ret_element' => ['TxnID', 'RefNumber']
+          }
+        }
+      }
+    }
+    assert_equal h, qbxml.from_qbxml("<?qbxml version=\"7.0\"?>\n<QBXML>\n  <QBXMLMsgsRq>\n    <InvoiceQueryRq>\n      <IncludeRetElement>TxnID</IncludeRetElement>\n    <IncludeRetElement>RefNumber</IncludeRetElement>\n    </InvoiceQueryRq>\n  </QBXMLMsgsRq>\n</QBXML>\n")
+  end
+
 end