Stop using inflections #2

Author: JasonBarnabe

lib/qbxml/hash.rb

@@ -15,7 +15,11 @@ class Qbxml::Hash < ::Hash
   def self.from_hash(hash, opts = {}, &block)
     key_proc = \
       if opts[:camelize]
-        lambda { |k| k.camelize } 
+        lambda { |k|
+          # QB wants things like ListID, not ListId. Adding inflections then using camelize can accomplish
+          # the same thing, but then the inflections will apply to everything the user does everywhere.
+          k.camelize.gsub(Qbxml::Types::ACRONYM_REGEXP) { "#{$1}#{$2.upcase}" }
+        }
       elsif opts[:underscore]
         lambda { |k| k.underscore } 
       end

lib/qbxml/types.rb

@@ -30,11 +30,11 @@ module Qbxml::Types
     "TIMEINTERVALTYPE" => STR_CAST
   }
 
+  # Strings in tag names that should be capitalized in QB's XML
   ACRONYMS = ['AP', 'AR', 'COGS', 'COM', 'UOM', 'QBXML', 'UI', 'AVS', 'ID',
               'PIN', 'SSN', 'COM', 'CLSID', 'FOB', 'EIN', 'UOM', 'PO', 'PIN', 'QB']
 
-  ActiveSupport::Inflector.inflections do |inflect|
-    ACRONYMS.each { |a| inflect.acronym a }
-  end
+  # Based on the regexp in ActiveSupport::Inflector.camelize
+  ACRONYM_REGEXP = Regexp.new("(?:(^|[a-z]|\\/))(#{ACRONYMS.map{|a| a.capitalize}.join("|")})")
 
 end

test/unit/hash_to_xml_test.rb

@@ -1,10 +1,47 @@
 require 'minitest/autorun'
 require 'qbxml'
 
-class VersionTest < Minitest::Test
+class HashToXmlTest < Minitest::Test
 
-  def test_hash_to_xml
-    assert_equal "<foo>\n  <bar>baz</bar>\n</foo>\n", Qbxml::Hash.to_xml({:foo => {:bar => 'baz'}}, {skip_instruct: true})
+  def test_hash_to_xml_customer_query
+    qbxml = Qbxml.new
+    assert_equal "<?qbxml version=\"7.0\"?>\n<QBXML>\n  <QBXMLMsgsRq>\n    <CustomerQueryRq>\n      <ListID>GUID-GOES-HERE</ListID>\n    </CustomerQueryRq>\n  </QBXMLMsgsRq>\n</QBXML>\n", qbxml.to_qbxml({:qbxml => {:qbxml_msgs_rq => {:customer_query_rq => {:list_id => 'GUID-GOES-HERE'}}}})
+  end
+
+  def test_hash_to_xml_invoice_mod
+    qbxml = Qbxml.new
+    xml = <<-EOF
+<?qbxml version="7.0"?>
+<QBXML>
+  <QBXMLMsgsRq>
+    <InvoiceModRq>
+      <InvoiceMod>
+        <TxnID>1929B9-1423150873</TxnID>
+        <EditSequence/>
+        <CustomerRef>
+          <ListID>4A50001-1013529664</ListID>
+        </CustomerRef>
+        <TxnDate>2015-01-28</TxnDate>
+        <RefNumber>12345678</RefNumber>
+        <Memo></Memo>
+        <InvoiceLineMod>
+          <TxnLineID>-1</TxnLineID>
+          <ItemRef>
+            <FullName>Sales</FullName>
+          </ItemRef>
+          <Desc>Contract 123</Desc>
+          <Quantity>23.44165</Quantity>
+          <Rate>515.0</Rate>
+          <SalesTaxCodeRef>
+            <FullName>E</FullName>
+          </SalesTaxCodeRef>
+        </InvoiceLineMod>
+      </InvoiceMod>
+    </InvoiceModRq>
+  </QBXMLMsgsRq>
+</QBXML>
+    EOF
+    assert_equal xml, qbxml.to_qbxml({:invoice_mod_rq=>{:invoice_mod=>{:txn_id=>"1929B9-1423150873", :edit_sequence=>nil, :customer_ref=>{:list_id=>"4A50001-1013529664"}, :txn_date=>"2015-01-28", :ref_number=>"12345678", :memo=>"", :invoice_line_mod=>[{:txn_line_id=>-1, :item_ref=>{:full_name=>"Sales"}, :desc=>"Contract 123", :quantity=>"23.44165", :rate=> 515.0, :sales_tax_code_ref=>{:full_name=>"E"}}]}}})
   end
 
   def test_array_of_strings

test/unit/xml_to_hash_test.rb

@@ -0,0 +1,13 @@
+require 'minitest/autorun'
+require 'qbxml'
+
+class XmlToHashTest < Minitest::Test
+
+  def test_xml_to_hash
+    qbxml = Qbxml.new
+    h = {"qbxml"=>{"xml_attributes"=>{}, "qbxml_msgs_rq"=>{"xml_attributes"=>{}, "customer_query_rq"=>{"xml_attributes"=>{}, "list_id"=>"GUID-GOES-HERE"}}}}
+    assert_equal h, qbxml.from_qbxml("<?qbxml version=\"7.0\"?>\n<QBXML>\n  <QBXMLMsgsRq>\n    <CustomerQueryRq>\n      <ListID>GUID-GOES-HERE</ListID>\n    </CustomerQueryRq>\n  </QBXMLMsgsRq>\n</QBXML>\n")
+  end
+
+end
+