lints

Author: agourlay

src/args.rs

@@ -46,7 +46,7 @@ pub struct Args {
     /// Optimizer indexing threshold
     #[arg(long)]
     pub indexing_threshold: Option<u32>,
-    /// Maximum size (in KiloBytes) of vectors to store in-memory per segment.
+    /// Maximum size (in `KiloBytes`) of vectors to store in-memory per segment.
     #[arg(long)]
     pub memmap_threshold: Option<u32>,
     /// Timeout of gRPC client

src/checker.rs

@@ -135,7 +135,7 @@ pub async fn check_points_consistency(
         Ok(())
     } else {
         let errors_rendered = errors_found.join("/n");
-        Err(Invariant(errors_rendered.to_string()))
+        Err(Invariant(errors_rendered))
     }
 }
 
@@ -244,11 +244,11 @@ pub fn check_search_result(results: &QueryBatchResponse) -> Result<(), CrasherEr
             .and_then(|v| v.vectors_options.as_ref())
         {
             let zeroed_vector = match vectors {
-                VectorsOptions::Vector(v) => check_zeroed_vector(v).then_some(("".to_string(), v)),
+                VectorsOptions::Vector(v) => check_zeroed_vector(v).then_some((String::new(), v)),
                 VectorsOptions::Vectors(vectors) => vectors
                     .vectors
                     .iter()
-                    .find_map(|(name, v)| check_zeroed_vector(v).then_some((name.to_string(), v))),
+                    .find_map(|(name, v)| check_zeroed_vector(v).then_some((name.clone(), v))),
             };
             if let Some((name, vector)) = zeroed_vector {
                 return Err(Invariant(format!(

src/client.rs

@@ -49,9 +49,8 @@ pub async fn wait_server_ready(
                     return Err(CrasherError::Invariant(
                         "Server did not start in time, /readyz not ready".to_string(),
                     ));
-                } else {
-                    log::debug!("Healthcheck failed: {err:?}")
                 }
+                log::debug!("Healthcheck failed: {err:?}");
             }
         }
     }
@@ -250,7 +249,9 @@ pub async fn create_collection(
         map: sparse_vector_params,
     };
 
-    let dense_vectors_config = if !args.only_sparse {
+    let dense_vectors_config = if args.only_sparse {
+        None
+    } else {
         let mut all_dense_params = HashMap::new();
 
         // dense vectors
@@ -266,8 +267,6 @@ pub async fn create_collection(
                 map: all_dense_params,
             })),
         })
-    } else {
-        None
     };
 
     let mut request = CreateCollectionBuilder::new(collection_name)

src/generators.rs

@@ -552,7 +552,7 @@ const WORDS: [&str; 8] = ["the", "quick", "fox", "jumps", "over", "the", "lazy",
 
 pub fn random_sentence(rng: &mut impl Rng, num_variants: u32) -> String {
     let variant = rng.random_range(0..num_variants);
-    let words: Vec<_> = WORDS.iter().take(variant as usize).cloned().collect();
+    let words: Vec<_> = WORDS.iter().take(variant as usize).copied().collect();
     words.join(" ")
 }
 

src/main.rs

@@ -49,7 +49,6 @@ async fn main() {
                     let grpc_client_config =
                         get_grpc_config(args.uris.first().unwrap(), args.grpc_timeout_ms as usize);
                     let grpc_client = Qdrant::new(grpc_client_config).unwrap();
-                    let grpc_client = Arc::new(grpc_client);
 
                     // HTTP client
                     let http_client = Client::builder()
@@ -78,7 +77,6 @@ async fn main() {
                     let (rng_seed, mut workload_rng, mut chaos_rng) = create_rngs(args.rng_seed);
 
                     // workload task
-                    let client_worker = grpc_client.clone();
                     let workload = Workload::new(
                         collection_name,
                         stopped.clone(),
@@ -89,6 +87,7 @@ async fn main() {
                         rng_seed,
                     );
                     let args = Arc::new(args);
+                    let client_worker = grpc_client.clone();
                     let workload_task = tokio::spawn(async move {
                         workload
                             .work(&client_worker, &http_client, args, &mut workload_rng)

src/workload.rs

@@ -59,7 +59,7 @@ impl Workload {
         let query_count = 2; //hardcoded
         let test_named_vectors = TestNamedVectors::new(duplication_factor, vec_dim);
         let write_ordering = None; // default
-        Workload {
+        Self {
             collection_name: collection_name.to_string(),
             test_named_vectors,
             query_count,
@@ -133,13 +133,12 @@ impl Workload {
                         // send stop signal to the main thread
                         self.stopped.store(true, Ordering::Relaxed);
                         break;
-                    } else {
-                        log::warn!(
-                            "Workload run failed due to client error - resuming soon\n{error:?}"
-                        );
-                        // no need to hammer the server while it restarts
-                        sleep(Duration::from_secs(3)).await;
                     }
+                    log::warn!(
+                        "Workload run failed due to client error - resuming soon\n{error:?}"
+                    );
+                    // no need to hammer the server while it restarts
+                    sleep(Duration::from_secs(3)).await;
                 }
             }
         }
@@ -301,7 +300,7 @@ impl Workload {
 
             log::info!("Run: delete existing points (all points by filter)");
             delete_points(client, &self.collection_name).await?;
-            self.reset_max_confirmed_point_id()
+            self.reset_max_confirmed_point_id();
         }
 
         // Validate existing collection snapshots
@@ -338,7 +337,7 @@ impl Workload {
                 self.data_consistency_check(client, restored_count).await?;
 
                 delete_points(client, &self.collection_name).await?;
-                self.reset_max_confirmed_point_id()
+                self.reset_max_confirmed_point_id();
             }
             log::info!("All snapshots validated and deleted!");
         }