Skip to content

Commit 4009b4d

Browse files
committed
Mypy fixes
1 parent 3d7cc75 commit 4009b4d

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

fastembed/common/model_description.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class ModelSource:
77
hf: Optional[str] = None
88
url: Optional[str] = None
99

10-
def __post_init__(self):
10+
def __post_init__(self) -> None:
1111
if self.hf is None and self.url is None:
1212
raise ValueError(
1313
f"At least one source should be set, current sources: hf={self.hf}, url={self.url}"
@@ -23,19 +23,11 @@ class ModelDescription:
2323

2424
description: str
2525
license: str
26-
size_in_GB: float
26+
size_in_GB: Optional[float]
2727
additional_files: List[str] = field(default_factory=list)
2828
tasks: Dict[str, int] = field(default_factory=dict)
2929

3030

31-
# @dataclass(frozen=True, kw_only=True)
32-
# class SparseModelDescription(ModelDescription):
33-
# vocab_size: int
34-
# requires_idf: Optional[bool] = None
35-
# # For sparse models, override dim to always be None.
36-
# dim: Optional[int] = None
37-
38-
3931
@dataclass(frozen=True)
4032
class SparseModelDescription(ModelDescription):
4133
_vocab_size: InitVar[Optional[int]] = None
@@ -53,7 +45,7 @@ def __init__(
5345
model_file: str,
5446
description: str,
5547
license: str,
56-
size_in_GB: float,
48+
size_in_GB: Optional[float],
5749
dim: Optional[int] = None,
5850
additional_files: Optional[List[str]] = None,
5951
tasks: Optional[Dict[str, int]] = None,

fastembed/late_interaction_multimodal/late_interaction_multimodal_embedding.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def list_supported_models(cls) -> list[ModelDescription]:
4141
]
4242
```
4343
"""
44-
result: list[dict[str, Any]] = []
44+
result: list[ModelDescription] = []
4545
for embedding in cls.EMBEDDINGS_REGISTRY:
4646
result.extend(embedding.list_supported_models())
4747
return result

fastembed/sparse/sparse_text_embedding.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
)
1010
from fastembed.sparse.splade_pp import SpladePP
1111
import warnings
12-
from fastembed.common.model_description import SparseModelDescription
12+
from fastembed.common.model_description import ModelDescription
1313

1414

1515
class SparseTextEmbedding(SparseTextEmbeddingBase):
1616
EMBEDDINGS_REGISTRY: list[Type[SparseTextEmbeddingBase]] = [SpladePP, Bm42, Bm25]
1717

1818
@classmethod
19-
def list_supported_models(cls) -> list[SparseModelDescription]:
19+
def list_supported_models(cls) -> list[ModelDescription]:
2020
"""
2121
Lists the supported models.
2222
@@ -39,7 +39,7 @@ def list_supported_models(cls) -> list[SparseModelDescription]:
3939
]
4040
```
4141
"""
42-
result: list[SparseModelDescription] = []
42+
result: list[ModelDescription] = []
4343
for embedding in cls.EMBEDDINGS_REGISTRY:
4444
result.extend(embedding.list_supported_models())
4545
return result

fastembed/text/text_embedding.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def list_supported_models(cls) -> list[ModelDescription]:
4545
]
4646
```
4747
"""
48-
result: list[dict[str, Any]] = []
48+
result: list[ModelDescription] = []
4949
for embedding in cls.EMBEDDINGS_REGISTRY:
5050
result.extend(embedding.list_supported_models())
5151
return result

0 commit comments

Comments
 (0)