Skip to content

Commit 4736f46

Browse files
authored
fix: check lowercase model name for warnings (#523)
1 parent c85e8c2 commit 4736f46

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

fastembed/sparse/sparse_text_embedding.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def __init__(
6262
**kwargs: Any,
6363
):
6464
super().__init__(model_name, cache_dir, threads, **kwargs)
65-
if model_name == "prithvida/Splade_PP_en_v1":
65+
if model_name.lower() == "prithvida/Splade_PP_en_v1".lower():
6666
warnings.warn(
6767
"The right spelling is prithivida/Splade_PP_en_v1. "
6868
"Support of this name will be removed soon, please fix the model_name",

fastembed/text/text_embedding.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def add_custom_model(
5555
) -> None:
5656
registered_models = cls._list_supported_models()
5757
for registered_model in registered_models:
58-
if model == registered_model.model:
58+
if model.lower() == registered_model.model.lower():
5959
raise ValueError(
6060
f"Model {model} is already registered in TextEmbedding, if you still want to add this model, "
6161
f"please use another model name"
@@ -88,18 +88,18 @@ def __init__(
8888
**kwargs: Any,
8989
):
9090
super().__init__(model_name, cache_dir, threads, **kwargs)
91-
if model_name == "nomic-ai/nomic-embed-text-v1.5-Q":
91+
if model_name.lower() == "nomic-ai/nomic-embed-text-v1.5-Q".lower():
9292
warnings.warn(
9393
"The model 'nomic-ai/nomic-embed-text-v1.5-Q' has been updated on HuggingFace. Please review "
9494
"the latest documentation on HF and release notes to ensure compatibility with your workflow. ",
9595
UserWarning,
9696
stacklevel=2,
9797
)
98-
if model_name in {
99-
"sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2",
100-
"thenlper/gte-large",
101-
"intfloat/multilingual-e5-large",
102-
"sentence-transformers/paraphrase-multilingual-mpnet-base-v2",
98+
if model_name.lower() in {
99+
"sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2".lower(),
100+
"thenlper/gte-large".lower(),
101+
"intfloat/multilingual-e5-large".lower(),
102+
"sentence-transformers/paraphrase-multilingual-mpnet-base-v2".lower(),
103103
}:
104104
warnings.warn(
105105
f"The model {model_name} now uses mean pooling instead of CLS embedding. "

0 commit comments

Comments
 (0)