Make .spec.restartAllPodsConcurrently a pointer to boolean (#123)

It allows the operator to detect if the value is set by requester, and if not,
apply the best restarting strategy, based on actual collection replication factor.

Author: pedjak

api/v1/qdrantcluster_types.go

@@ -118,10 +118,11 @@ type QdrantClusterSpec struct {
 	PodDisruptionBudget *policyv1.PodDisruptionBudgetSpec `json:"podDisruptionBudget,omitempty"`
 	// RestartAllPodsConcurrently specifies whether to restart all pods concurrently (also called one-shot-restart).
 	// If enabled, all the pods in the cluster will be restarted concurrently in situations where multiple pods
-	// need to be restarted like when RestartedAtAnnotationKey is added/updated or the Qdrant version need to be upgraded.
-	// This helps sharded but not replicated clusters to reduce downtime to possible minimum during restart.
+	// need to be restarted, like when RestartedAtAnnotationKey is added/updated or the Qdrant version needs to be upgraded.
+	// This helps sharded but not replicated clusters to reduce downtime to a possible minimum during restart.
+	// If unset, the operator is going to restart nodes concurrently if none of the collections if replicated.
 	// +optional
-	RestartAllPodsConcurrently bool `json:"restartAllPodsConcurrently,omitempty"`
+	RestartAllPodsConcurrently *bool `json:"restartAllPodsConcurrently"`
 	// If StartupDelaySeconds is set (> 0), an additional 'sleep <value>' will be emitted to the pod startup.
 	// The sleep will be added when a pod is restarted, it will not force any pod to restart.
 	// This feature can be used for debugging the core, e.g. if a pod is in crash loop, it provided a way

api/v1/zz_generated.deepcopy.go

@@ -610,8 +610,9 @@ spec:
                 description: |-
                   RestartAllPodsConcurrently specifies whether to restart all pods concurrently (also called one-shot-restart).
                   If enabled, all the pods in the cluster will be restarted concurrently in situations where multiple pods
-                  need to be restarted like when RestartedAtAnnotationKey is added/updated or the Qdrant version need to be upgraded.
-                  This helps sharded but not replicated clusters to reduce downtime to possible minimum during restart.
+                  need to be restarted, like when RestartedAtAnnotationKey is added/updated or the Qdrant version needs to be upgraded.
+                  This helps sharded but not replicated clusters to reduce downtime to a possible minimum during restart.
+                  If unset, the operator is going to restart nodes concurrently if none of the collections if replicated.
                 type: boolean
               security:
                 description: Security specifies the security context for each Qdrant

charts/qdrant-kubernetes-api/templates/region-crds/qdrant.io_qdrantclusters.yaml

@@ -609,8 +609,9 @@ spec:
                 description: |-
                   RestartAllPodsConcurrently specifies whether to restart all pods concurrently (also called one-shot-restart).
                   If enabled, all the pods in the cluster will be restarted concurrently in situations where multiple pods
-                  need to be restarted like when RestartedAtAnnotationKey is added/updated or the Qdrant version need to be upgraded.
-                  This helps sharded but not replicated clusters to reduce downtime to possible minimum during restart.
+                  need to be restarted, like when RestartedAtAnnotationKey is added/updated or the Qdrant version needs to be upgraded.
+                  This helps sharded but not replicated clusters to reduce downtime to a possible minimum during restart.
+                  If unset, the operator is going to restart nodes concurrently if none of the collections if replicated.
                 type: boolean
               security:
                 description: Security specifies the security context for each Qdrant

crds/qdrant.io_qdrantclusters.yaml

@@ -731,7 +731,7 @@ _Appears in:_
 | `storageClassNames` _[StorageClassNames](#storageclassnames)_ | StorageClassNames specifies the storage class names for db and snapshots. |  |  |
 | `topologySpreadConstraints` _[TopologySpreadConstraint](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#topologyspreadconstraint-v1-core)_ | TopologySpreadConstraints specifies the topology spread constraints for the cluster. |  |  |
 | `podDisruptionBudget` _[PodDisruptionBudgetSpec](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#poddisruptionbudgetspec-v1-policy)_ | PodDisruptionBudget specifies the pod disruption budget for the cluster. |  |  |
-| `restartAllPodsConcurrently` _boolean_ | RestartAllPodsConcurrently specifies whether to restart all pods concurrently (also called one-shot-restart).<br />If enabled, all the pods in the cluster will be restarted concurrently in situations where multiple pods<br />need to be restarted like when RestartedAtAnnotationKey is added/updated or the Qdrant version need to be upgraded.<br />This helps sharded but not replicated clusters to reduce downtime to possible minimum during restart. |  |  |
+| `restartAllPodsConcurrently` _boolean_ | RestartAllPodsConcurrently specifies whether to restart all pods concurrently (also called one-shot-restart).<br />If enabled, all the pods in the cluster will be restarted concurrently in situations where multiple pods<br />need to be restarted, like when RestartedAtAnnotationKey is added/updated or the Qdrant version needs to be upgraded.<br />This helps sharded but not replicated clusters to reduce downtime to a possible minimum during restart.<br />If unset, the operator is going to restart nodes concurrently if none of the collections if replicated. |  |  |
 | `startupDelaySeconds` _integer_ | If StartupDelaySeconds is set (> 0), an additional 'sleep <value>' will be emitted to the pod startup.<br />The sleep will be added when a pod is restarted, it will not force any pod to restart.<br />This feature can be used for debugging the core, e.g. if a pod is in crash loop, it provided a way<br />to inspect the attached storage. |  |  |
 | `rebalanceStrategy` _[RebalanceStrategy](#rebalancestrategy)_ | RebalanceStrategy specifies the strategy to use for automaticially rebalancing shards the cluster.<br />Cluster-manager needs to be enabled for this feature to work. |  |  |