Remove GetQdrantClusterCrdForHash helper (#116)

The helper is moved to the operator codebase, given that is only used by the operator
internally to detect if pods needs to be restart on QdrantCluster update.

Author: pedjak

api/v1/qdrantcluster_types.go

@@ -31,49 +31,6 @@ const (
 	RecreateNodeAnnotationKey = "operator.qdrant.com/recreate-node"
 )
 
-// GetQdrantClusterCrdForHash creates a QdrantCluster for the use of creating a hash for the provided QdrantCluster,
-// It uses a subset only, so it ignores e.g. majority of the the status and some fields from the spec.
-func GetQdrantClusterCrdForHash(qc QdrantCluster) QdrantCluster {
-	// Only include the items to be inspected (basically the spec and a single annot)
-	result := QdrantCluster{
-		ObjectMeta: metav1.ObjectMeta{
-			Annotations: map[string]string{},
-		},
-	}
-	// Add the restartAt annot if needed
-	if annots := qc.GetAnnotations(); annots != nil {
-		if val, found := annots[RestartedAtAnnotationKey]; found {
-			result.Annotations[RestartedAtAnnotationKey] = val
-		}
-	}
-	cloned := qc.Spec.DeepCopy()
-	// Version is a special case, we can upgrade via an upgade-path,
-	// so we should take care of the version in status instead
-	if v := qc.Status.Version; v != "" {
-		cloned.Version = v
-	}
-	// Remove all fields (aka set a fixed value) which shouldn't restart the pod
-	// The list is sorted alphabetically, for easier maintainability
-	cloned.ClusterManager = nil
-	cloned.Ingress = nil
-	cloned.Pauses = nil
-	cloned.Resources.Storage = ""
-	cloned.RestartAllPodsConcurrently = false
-	cloned.Service = nil
-	cloned.ServicePerNode = nil
-	cloned.Size = 1
-	if v := cloned.StatefulSet; v != nil {
-		v.Annotations = nil
-	}
-	cloned.StartupDelaySeconds = nil
-	cloned.StorageClassNames = nil
-	cloned.Suspend = false
-	// Set Spec for result
-	result.Spec = *cloned
-	// Return result
-	return result
-}
-
 type GPUType string
 
 //goland:noinspection GoUnusedConst

api/v1/qdrantcluster_types_test.go

@@ -1,12 +1,8 @@
 package v1
 
 import (
-	"crypto/sha256"
-	"encoding/json"
-	"fmt"
 	"testing"
 
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -21,51 +17,3 @@ func TestValidate(t *testing.T) {
 	require.Error(t, err)
 	require.ErrorContains(t, err, "Spec.Resources.CPU error: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'")
 }
-
-func TestGetQdrantClusterCrdForHash(t *testing.T) {
-	qc := QdrantCluster{}
-	hash, err := getQdrantClusterCrdHash(qc)
-	require.NoError(t, err)
-	assert.Equal(t, "523a8cb", hash)
-
-	falseVal := false
-	qc.Spec.ServicePerNode = &falseVal
-	hash, err = getQdrantClusterCrdHash(qc)
-	require.NoError(t, err)
-	assert.Equal(t, "523a8cb", hash)
-
-	trueVal := true
-	qc.Spec.ServicePerNode = &trueVal
-	hash, err = getQdrantClusterCrdHash(qc)
-	require.NoError(t, err)
-	assert.Equal(t, "523a8cb", hash)
-}
-
-// getQdrantClusterCrdHash created a hash for the provided QdrantCluster,
-// however a subset only, see GetQdrantClusterCrdForHash for details.
-func getQdrantClusterCrdHash(qc QdrantCluster) (string, error) {
-	inspect := GetQdrantClusterCrdForHash(qc)
-	// Get the hash, so we can diff later
-	hash, err := getHash(inspect)
-	if err != nil {
-		return "", fmt.Errorf("failed to get hash for QdrantCluster: %w", err)
-	}
-	return hash, err
-}
-
-// Get hash of provided value.
-// Returns the first 7 characters of the hash (like GitHub).
-func getHash(v any) (string, error) {
-	json, err := json.Marshal(v)
-	if err != nil {
-		return "", fmt.Errorf("marshal failed: %w", err)
-	}
-	// Initialize hash
-	hash := sha256.New()
-	// add the serialized content
-	hash.Write(json)
-	// close hash
-	sum := hash.Sum(nil)
-	// Return first 7 characters
-	return fmt.Sprintf("%x", sum)[:7], nil
-}