Fix/lazy load local mode (#1134)

* Fix: Lazy load QdrantLocal to support read-only envs

* Fix: Lazy load QdrantLocal to support read-only envs

* Fix: Regenerate async client using Python 3.10 to match CI

* chore: add comments to portalocker import

---------

Co-authored-by: Kirstin <[email protected]>
Co-authored-by: George Panchuk <[email protected]>

Author: 3 people

qdrant_client/local/async_qdrant_local.py

@@ -20,7 +20,6 @@
 from typing import Any, Generator, Iterable, Mapping, Sequence, get_args
 from uuid import uuid4
 import numpy as np
-import portalocker
 from qdrant_client.common.client_warnings import show_warning, show_warning_once
 from qdrant_client._pydantic_compat import to_dict
 from qdrant_client.async_client_base import AsyncQdrantBase
@@ -83,6 +82,8 @@ async def close(self, **kwargs: Any) -> None:
                 )
         try:
             if self._flock_file is not None and (not self._flock_file.closed):
+                import portalocker
+
                 portalocker.unlock(self._flock_file)
                 self._flock_file.close()
         except TypeError:
@@ -124,6 +125,8 @@ def _load(self) -> None:
             with open(lock_file_path, "w") as f:
                 f.write("tmp lock file")
         self._flock_file = open(lock_file_path, "r+")
+        import portalocker
+
         try:
             portalocker.lock(
                 self._flock_file,

qdrant_client/local/qdrant_local.py

@@ -17,7 +17,6 @@
 from uuid import uuid4
 
 import numpy as np
-import portalocker
 
 from qdrant_client.common.client_warnings import show_warning, show_warning_once
 from qdrant_client._pydantic_compat import to_dict
@@ -83,6 +82,9 @@ def close(self, **kwargs: Any) -> None:
 
         try:
             if self._flock_file is not None and not self._flock_file.closed:
+                import portalocker  # `portalocker` can't be imported at the top level: it checks for writeable
+                # directories on import and crashes in read-only systems even if local mode is not used
+
                 portalocker.unlock(self._flock_file)
                 self._flock_file.close()
         except TypeError:  # sometimes portalocker module can be garbage collected before
@@ -134,6 +136,10 @@ def _load(self) -> None:
             with open(lock_file_path, "w") as f:
                 f.write("tmp lock file")
         self._flock_file = open(lock_file_path, "r+")
+
+        import portalocker  # `portalocker` can't be imported at the top level: it checks for writeable directories
+        # on import and crashes in read-only systems even if local mode is not used
+
         try:
             portalocker.lock(
                 self._flock_file,