Skip to content

Commit 9d1c467

Browse files
committed
use constant for MARGIN
1 parent 23ea788 commit 9d1c467

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

qdrant_client/local/distances.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
EPSILON = 1.1920929e-7 # https://doc.rust-lang.org/std/f32/constant.EPSILON.html
1111
# https://github.com/qdrant/qdrant/blob/7164ac4a5987d28f1c93f5712aef8e09e7d93555/lib/segment/src/spaces/simple_avx.rs#L99C10-L99C10
1212

13+
NAIVE_FEEDBACK_CONFIDENCE_MARGIN = 0.0
14+
1315

1416
class DistanceOrder(str, Enum):
1517
BIGGER_IS_BETTER = "bigger_is_better"
@@ -57,6 +59,7 @@ class ContextQuery:
5759
def __init__(self, context_pairs: list[ContextPair]):
5860
self.context_pairs = context_pairs
5961

62+
6063
class FeedbackItem:
6164
def __init__(self, vector: list[float], score: float):
6265
self.vector = np.array(vector)
@@ -336,6 +339,7 @@ def calculate_context_scores(
336339

337340
return overall_scores
338341

342+
339343
def calculate_naive_feedback_query(
340344
query: NaiveFeedbackQuery, vectors: types.NumpyArray, distance_type: models.Distance
341345
) -> types.NumpyArray:
@@ -345,7 +349,7 @@ def calculate_naive_feedback_query(
345349
positive_item, negative_item = p[0], p[1]
346350
confidence = positive_item.score - negative_item.score
347351

348-
if confidence <= 0.0:
352+
if confidence <= NAIVE_FEEDBACK_CONFIDENCE_MARGIN:
349353
continue
350354

351355
partial_computation = (confidence**query.coefficients.b) * query.coefficients.c

0 commit comments

Comments
 (0)