Skip to content

Commit 4136dbe

Browse files
authored
Enable all feature flags for collection-reload (#249)
* Set QDRANT__FEATURE_FLAGS__ALL=true for reload collection benchmark * Update workflow * Fix fw * Add log lines * Remove debug lvl
1 parent 1854b0d commit 4136dbe

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

.github/workflows/continuous-benchmark-2.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ name: Continuous Benchmark 2
33
on:
44
repository_dispatch:
55
workflow_dispatch:
6+
inputs:
7+
feature_flags_all:
8+
type: boolean
9+
description: "Enable all feature flags (true by default)"
10+
default: true
611
schedule:
712
# Run every day at midnight
813
- cron: "0 0 * * *"
@@ -29,6 +34,7 @@ jobs:
2934
export POSTGRES_PASSWORD=${{ secrets.POSTGRES_PASSWORD }}
3035
export POSTGRES_HOST=${{ secrets.POSTGRES_HOST }}
3136
export SERVER_NAME="benchmark-server-3"
37+
export QDRANT__FEATURE_FLAGS__ALL=${{ inputs.feature_flags_all }}
3238
bash -x tools/setup_ci.sh
3339
3440
set +e

engine/servers/qdrant-continuous-benchmarks-snapshot/docker-compose.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ services:
55
image: ${CONTAINER_REGISTRY:-docker.io}/qdrant/qdrant:${QDRANT_VERSION}
66
container_name: qdrant-continuous
77
environment:
8-
QDRANT_NUM_CPUS: 4
8+
- QDRANT_NUM_CPUS=4
9+
- QDRANT__FEATURE_FLAGS__ALL=${QDRANT__FEATURE_FLAGS__ALL:-true}
910
ports:
1011
- "6333:6333"
1112
- "6334:6334"

tools/run_client_script.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ PRIVATE_IP_OF_THE_SERVER=$(bash "${SCRIPT_PATH}/${CLOUD_NAME}/get_private_ip.sh"
2727

2828
if [[ "$EXPERIMENT_MODE" == "snapshot" ]]; then
2929
scp "${SCRIPT_PATH}/run_experiment.sh" "${SERVER_USERNAME}@${IP_OF_THE_CLIENT}:~/run_experiment_snapshot.sh"
30+
scp "${SCRIPT_PATH}/../datasets/datasets.json" "${SERVER_USERNAME}@${IP_OF_THE_CLIENT}:~/datasets.json"
3031

3132
RUN_EXPERIMENT="ENGINE_NAME=${ENGINE_NAME} \
3233
DATASETS=${DATASETS} \

tools/run_experiment.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ fi
4848
echo "Ensure datasets volume exists and contains latest datasets.json"
4949
docker volume create ci-datasets
5050
if [[ -f "$HOME/datasets.json" ]]; then
51-
echo "Found datasets.json, update the volume"
51+
echo "Found datasets.json, move it into the volume"
5252
mv ~/datasets.json "$(docker volume inspect ci-datasets -f '{{ .Mountpoint }}')"
5353
else
54-
echo "datasets.json is missing, do not update the volume"
54+
echo "datasets.json is missing, skip moving it into the volume"
5555
fi
5656

5757
if [[ "$EXPERIMENT_MODE" == "full" ]] || [[ "$EXPERIMENT_MODE" == "upload" ]]; then
@@ -121,10 +121,11 @@ fi
121121

122122
if [[ "$EXPERIMENT_MODE" == "snapshot" ]]; then
123123
echo "EXPERIMENT_MODE=$EXPERIMENT_MODE"
124-
124+
echo "Recovering collection from snapshot"
125125
curl -X PUT \
126126
"http://${PRIVATE_IP_OF_THE_SERVER}:6333/collections/benchmark/snapshots/recover" \
127127
--data-raw "{\"location\": \"${SNAPSHOT_URL}\"}"
128+
echo "Done recovering collection from snapshot"
128129

129130
collection_url="http://${PRIVATE_IP_OF_THE_SERVER}:6333/collections/benchmark"
130131
collection_status=$(curl -s "$collection_url" | jq -r '.result.status')

0 commit comments

Comments
 (0)