[Postgres] When renaming QgsProject in PostgreSQL copy also comment (#64705)

* if comment column exist, copy value when renaming project

* add renameProject()

* update trigger to handle renames

* simplify the renaming project command

* if current project was renamed, apply it also in the session

* fix precommit

* remove unused variable

Author: JanCaha

src/providers/postgres/qgspostgresdataitemguiprovider.cpp

@@ -935,29 +935,26 @@ void QgsPostgresDataItemGuiProvider::renameProject( QgsPGProjectItem *projectIte
     return;
   }
 
+  QgsProject *project = QgsProject::instance();
+
   QgsNewNameDialog dlg( tr( "project “%1”" ).arg( projectItem->name() ), projectItem->name(), QStringList(), QgsPostgresUtils::projectNamesInSchema( conn, projectItem->schemaName() ) );
   dlg.setWindowTitle( tr( "Rename Project" ) );
   if ( dlg.exec() != QDialog::Accepted || dlg.name() == projectItem->name() )
     return;
 
-  const QString newUri = projectItem->uriWithNewName( dlg.name() );
-
-  // read the project, set title and new filename
-  QgsProject project;
-  project.read( projectItem->path() );
-  project.setTitle( dlg.name() );
-  project.setFileName( newUri );
+  QgsPostgresProjectUri pgProjectUri;
+  pgProjectUri.connInfo = conn->uri();
+  pgProjectUri.schemaName = projectItem->schemaName();
+  pgProjectUri.projectName = projectItem->name();
 
-  // write project to the database
-  const bool success = project.write();
-  if ( !success )
+  // if project fileName is same as the selected project encoded uri, then update current project with new fileName
+  if ( project->fileName() == QgsPostgresProjectStorage::encodeUri( pgProjectUri ) )
   {
-    notify( tr( "Rename Project" ), tr( "Unable to rename project “%1” to “%2”" ).arg( projectItem->name(), dlg.name() ), context, Qgis::MessageLevel::Warning );
-    conn->unref();
-    return;
+    pgProjectUri.projectName = dlg.name();
+    project->setFileName( QgsPostgresProjectStorage::encodeUri( pgProjectUri ) );
   }
 
-  if ( !QgsPostgresUtils::deleteProjectFromSchema( conn, projectItem->name(), projectItem->schemaName() ) )
+  if ( !QgsPostgresUtils::renameProject( conn, projectItem->schemaName(), projectItem->name(), dlg.name() ) )
   {
     notify( tr( "Rename Project" ), tr( "Unable to rename project “%1” to “%2”" ).arg( projectItem->name(), dlg.name() ), context, Qgis::MessageLevel::Warning );
     conn->unref();

src/providers/postgres/qgspostgresutils.cpp

@@ -750,6 +750,9 @@ BEGIN
         WHERE name = OLD.NAME;
 
     ELSIF TG_OP = 'UPDATE' THEN
+      IF NEW.name IS DISTINCT FROM OLD.name THEN
+        UPDATE %1.qgis_projects_versions SET name = NEW.name WHERE name = OLD.name;
+      END IF;
       IF NEW.content IS DISTINCT FROM OLD.content THEN
           INSERT INTO %1.qgis_projects_versions ( name, metadata, content, comment, date_saved )
             VALUES (OLD.name, OLD.metadata, OLD.content, OLD.comment,
@@ -839,6 +842,22 @@ bool QgsPostgresUtils::moveProjectVersions( QgsPostgresConn *conn, const QString
   return true;
 }
 
+bool QgsPostgresUtils::renameProject( QgsPostgresConn *conn, const QString &schemaName, const QString &oldProjectName, const QString &newProjectName )
+{
+  const QString sql = u"UPDATE %1.qgis_projects SET name=%2 WHERE name=%3"_s
+                        .arg( QgsPostgresConn::quotedIdentifier( schemaName ) )
+                        .arg( QgsPostgresConn::quotedValue( newProjectName ) )
+                        .arg( QgsPostgresConn::quotedValue( oldProjectName ) );
+
+  QgsPostgresResult result( conn->PQexec( sql ) );
+  if ( result.PQresultStatus() != PGRES_COMMAND_OK )
+  {
+    return false;
+  }
+
+  return true;
+}
+
 QStringList QgsPostgresUtils::projectNamesInSchema( QgsPostgresConn *conn, const QString &schema )
 {
   QStringList projects;

src/providers/postgres/qgspostgresutils.h

@@ -208,6 +208,13 @@ class QgsPostgresUtils
      */
     static bool moveProjectVersions( QgsPostgresConn *conn, const QString &originalSchema, const QString &project, const QString &targetSchema );
 
+    /**
+     * Renames a project in the specified schema.
+     *
+     * \since QGIS 4.0
+     */
+    static bool renameProject( QgsPostgresConn *conn, const QString &schemaName, const QString &oldProjectName, const QString &newProjectName );
+
     /**
      * List projects in the specified \a schema
      *