Merge pull request #914 from elicn/posix-fixes

POSIX Fixes

Author: xwings

qiling/os/memory.py

@@ -281,12 +281,7 @@ def write(self, addr: int, data: bytes) -> None:
             data: bytes to write
         """
 
-        try:
-            self.ql.uc.mem_write(addr, data)
-        except:
-            self.ql.log.debug(f'addresss write length: {len(data):d}')
-            self.ql.log.error(f'addresss write error: {addr:#x}')
-            raise
+        self.ql.uc.mem_write(addr, data)
 
     def search(self, needle: bytes, begin: int = None, end: int = None) -> Sequence[int]:
         """Search for a sequence of bytes in memory.

qiling/os/posix/syscall/sched.py

@@ -44,7 +44,6 @@ def ql_syscall_clone(ql: Qiling, flags: int, child_stack: int, parent_tidptr: in
         newtls = ori_newtls
 
     f_th = ql.os.thread_management.cur_thread
-    newtls = None
     set_child_tid_addr = None
 
     # Shared virtual memory

qiling/os/posix/syscall/uio.py

@@ -38,7 +38,7 @@ def ql_syscall_readv(ql: Qiling, fd: int, vec: int, vlen: int):
 
         if hasattr(ql.os.fd[fd], 'read'):
             data = ql.os.fd[fd].read(l)
-            ql.log.debug(f'{data.decode()!r}')
+            ql.log.debug(f'{data!r}')
             ql.mem.write(addr, data)
 
     return regreturn

qiling/os/posix/syscall/unistd.py

@@ -247,11 +247,12 @@ def ql_syscall_read(ql: Qiling, fd, buf: int, length: int):
         try:
             data = ql.os.fd[fd].read(length)
             ql.mem.write(buf, data)
-
-            ql.log.debug(f'read() CONTENT: {data.decode()!r}')
-            regreturn = len(data)
         except:
             regreturn = -EBADF
+        else:
+            ql.log.debug(f'read() CONTENT: {data!r}')
+            regreturn = len(data)
+
     else:
         regreturn = -EBADF
 
@@ -261,9 +262,10 @@ def ql_syscall_read(ql: Qiling, fd, buf: int, length: int):
 def ql_syscall_write(ql: Qiling, fd: int, buf: int, count: int):
     try:
         data = ql.mem.read(buf, count)
-
-        if data:
-            ql.log.debug(f'write() CONTENT: {data.decode()!r}')
+    except:
+        regreturn = -1
+    else:
+        ql.log.debug(f'write() CONTENT: {data.decode()!r}')
 
         if hasattr(ql.os.fd[fd], 'write'):
             ql.os.fd[fd].write(data)
@@ -272,12 +274,6 @@ def ql_syscall_write(ql: Qiling, fd: int, buf: int, count: int):
 
         regreturn = count
 
-    except:
-        regreturn = -1
-
-        if ql.verbose >= QL_VERBOSE.DEBUG:
-            raise
-
     return regreturn