Skip to content

Commit afaf708

Browse files
authored
Some comments about why we need multiprocess in test_pe
1 parent beb5452 commit afaf708

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tests/test_pe.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
from qiling.os.mapper import QlFsMappedObject
1919
import multiprocess as mb
2020

21+
# On Windows, the CPython GC is too conservative and may hold too
22+
# many Unicorn objects (nearly 16GB) until free-ing them which may
23+
# cause failure during tests.
24+
#
25+
# Use subprocess to make sure resources are free-ed when the subprocess
26+
# is killed.
2127
class QLWinSingleTest:
2228

2329
def __init__(self, test):
@@ -39,7 +45,7 @@ def run(self):
3945
if "exception" not in results:
4046
return results['result']
4147
else:
42-
raise results['exceptions']
48+
raise results['exception']
4349

4450

4551
class TestOut:

0 commit comments

Comments
 (0)