Move get_syscall_mapper to POSIX

Author: elicn

qiling/os/posix/posix.py

@@ -26,7 +26,7 @@
 from qiling.exception import QlErrorSyscallNotFound
 from qiling.os.os import QlOs
 from qiling.os.posix.const import NR_OPEN, errors
-from qiling.utils import ql_get_module_function, ql_syscall_mapping_function
+from qiling.utils import ql_get_module_function
 
 SYSCALL_PREF: str = f'ql_syscall_'
 
@@ -137,7 +137,7 @@ def __init__(self, ql: Qiling):
         }[self.ql.arch.type](self.ql.arch)
 
         # select syscall mapping function based on emulated OS and architecture
-        self.syscall_mapper = ql_syscall_mapping_function(self.type, self.ql.arch.type)
+        self.syscall_mapper = self.__get_syscall_mapper(self.ql.arch.type)
 
         self._fd = QlFileDes()
 
@@ -150,6 +150,14 @@ def __init__(self, ql: Qiling):
 
         self._shms = {}
 
+    def __get_syscall_mapper(self, archtype: QL_ARCH):
+        qlos_path = f'.os.{self.type.name.lower()}.map_syscall'
+        qlos_func = 'get_syscall_mapper'
+
+        func = ql_get_module_function(qlos_path, qlos_func)
+
+        return func(archtype)
+
     @QlOs.stdin.setter
     def stdin(self, stream: TextIO) -> None:
         self._stdin = stream

qiling/utils.py

@@ -84,15 +84,6 @@ def ql_get_module_function(module_name: str, function_name: str):
 
     return module_function
 
-# This function is extracted from os_setup (QlOsPosix) so I put it here.
-def ql_syscall_mapping_function(ostype: QL_OS, archtype: QL_ARCH):
-    qlos_name = ostype.name
-    qlos_path = f'qiling.os.{qlos_name.lower()}.map_syscall'
-    qlos_func = 'get_syscall_mapper'
-
-    func = ql_get_module_function(qlos_path, qlos_func)
-
-    return func(archtype)
 
 def __emu_env_from_pathname(path: str) -> Tuple[Optional[QL_ARCH], Optional[QL_OS], Optional[QL_ENDIAN]]:
     if os.path.isdir(path) and path.endswith('.kext'):