Skip to content

Commit 2edc81b

Browse files
author
YangSen-qn
committed
Merge branch 'refactor' into uc_query_v4
2 parents 3fa23ce + 13eef78 commit 2edc81b

File tree

6 files changed

+21
-16
lines changed

6 files changed

+21
-16
lines changed

library/src/androidTest/java/com/qiniu/android/AsynTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public void run() {
7070
@Override
7171
public void run() {
7272

73-
if (Thread.currentThread().getName().equals("main")){
73+
if (Thread.currentThread() == Looper.getMainLooper().getThread()){
7474
testParam.successCount += 1;
7575
}
7676

@@ -112,7 +112,7 @@ public void testAsyncBg(){
112112
@Override
113113
public void run() {
114114
String threadName = Thread.currentThread().getName();
115-
if (!threadName.equals("main")){
115+
if (Thread.currentThread() != Looper.getMainLooper().getThread()){
116116
synchronized (this){
117117
testParam.successCount += 1;
118118
}

library/src/androidTest/java/com/qiniu/android/DnsCacheFileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class DnsCacheFileTest extends BaseTest {
1010

1111
public void testCreate(){
1212
try {
13-
DnsCacheFile file = new DnsCacheFile("");
13+
DnsCacheFile file = new DnsCacheFile(null);
1414
if (file != null){
1515
assertTrue(false);
1616
}

library/src/main/java/com/qiniu/android/http/dns/DnsCacheFile.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,20 @@ public class DnsCacheFile implements Recorder {
1616
public File f;
1717

1818
public DnsCacheFile(String directory) throws IOException {
19+
if (directory == null) {
20+
throw new IOException("directory invalid");
21+
}
22+
1923
this.directory = directory;
2024
f = new File(directory);
21-
if (!f.isDirectory() || !f.exists()) {
25+
26+
if (!f.exists()) {
2227
boolean r = f.mkdirs();
2328
if (!r) {
2429
throw new IOException("mkdir failed");
2530
}
26-
return;
2731
}
32+
2833
if (!f.isDirectory()) {
2934
throw new IOException("does not mkdir");
3035
}

library/src/main/java/com/qiniu/android/http/dns/DnsCacheInfo.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,16 @@ public class DnsCacheInfo implements java.io.Serializable {
2020
public String localIp;
2121
public ConcurrentHashMap<String, List<IDnsNetworkAddress>> info;
2222

23-
public static DnsCacheInfo createDnsCacheInfoByJsonData(byte[] jsonData) {
23+
public static DnsCacheInfo createDnsCacheInfoByData(byte[] jsonData) {
2424
if (jsonData == null){
2525
return null;
2626
}
27-
DnsCacheInfo dnsCacheInfo = (DnsCacheInfo)StringUtils.toObject(jsonData);
28-
return dnsCacheInfo;
27+
Object dnsCacheInfo = StringUtils.toObject(jsonData);
28+
if (dnsCacheInfo instanceof DnsCacheInfo){
29+
return (DnsCacheInfo)dnsCacheInfo;
30+
} else {
31+
return null;
32+
}
2933
}
3034

3135
public DnsCacheInfo() {

library/src/main/java/com/qiniu/android/http/dns/DnsPrefetcher.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,15 @@
88
import com.qiniu.android.http.ResponseInfo;
99
import com.qiniu.android.http.metrics.UploadRegionRequestMetrics;
1010
import com.qiniu.android.storage.GlobalConfiguration;
11-
import com.qiniu.android.storage.Recorder;
1211
import com.qiniu.android.storage.UpToken;
1312
import com.qiniu.android.utils.AndroidNetwork;
14-
import com.qiniu.android.utils.StringUtils;
1513
import com.qiniu.android.utils.Utils;
1614
import com.qiniu.android.utils.Wait;
1715

18-
import org.json.JSONArray;
19-
import org.json.JSONException;
20-
import org.json.JSONObject;
21-
2216
import java.io.IOException;
2317
import java.net.UnknownHostException;
2418
import java.util.ArrayList;
2519
import java.util.Arrays;
26-
import java.util.Iterator;
2720
import java.util.List;
2821
import java.util.concurrent.ConcurrentHashMap;
2922

@@ -226,7 +219,7 @@ private boolean preFetchHost(String preHost, Dns dns){
226219

227220
private boolean recoverDnsCache(byte[] data){
228221

229-
DnsCacheInfo dnsCacheInfo = DnsCacheInfo.createDnsCacheInfoByJsonData(data);
222+
DnsCacheInfo dnsCacheInfo = DnsCacheInfo.createDnsCacheInfoByData(data);
230223
if (dnsCacheInfo == null || dnsCacheInfo.info == null || dnsCacheInfo.info.size() == 0){
231224
return false;
232225
}

library/src/main/java/com/qiniu/android/storage/UploadManager.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,12 +333,15 @@ private void completeAction(final String token,
333333

334334
reportQuality(responseInfo, taskMetrics, token);
335335
if (completionHandler != null){
336+
final Wait wait = new Wait();
336337
AsyncRun.runInMain(new Runnable() {
337338
@Override
338339
public void run() {
339340
completionHandler.complete(key, responseInfo, response);
341+
wait.stopWait();
340342
}
341343
});
344+
wait.startWait();
342345
}
343346
}
344347

0 commit comments

Comments
 (0)