Skip to content

Commit 5cc405e

Browse files
committed
change cancel behavior
1 parent 0a82711 commit 5cc405e

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

library/src/main/java/com/qiniu/android/storage/FormUploader.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,12 @@ public void onProgress(int bytesWritten, int totalSize) {
103103
CompletionHandler completion = new CompletionHandler() {
104104
@Override
105105
public void complete(ResponseInfo info, JSONObject response) {
106-
if(options.cancellationSignal != null && options.cancellationSignal.isCancelled()){
107-
ResponseInfo i = ResponseInfo.cancelled();
108-
completionHandler.complete(key, i, null);
109-
return;
110-
}
111106
if (info.isOK()) {
112107
options.progressHandler.progress(key, 1.0);
113108
completionHandler.complete(key, info, response);
109+
} else if(options.cancellationSignal.isCancelled()){
110+
ResponseInfo i = ResponseInfo.cancelled();
111+
completionHandler.complete(key, i, null);
114112
} else if (info.needRetry()) {
115113
CompletionHandler retried = new CompletionHandler() {
116114
@Override

library/src/main/java/com/qiniu/android/storage/ResumeUploader.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,18 +173,19 @@ private void nextTask(final int offset, final int retried, final String host) {
173173
CompletionHandler complete = new CompletionHandler() {
174174
@Override
175175
public void complete(ResponseInfo info, JSONObject response) {
176-
if(isCancelled()){
177-
ResponseInfo i = ResponseInfo.cancelled();
178-
completionHandler.complete(key, i, null);
179-
return;
180-
}
181176
if (info.isOK()) {
182177
removeRecord();
183178
options.progressHandler.progress(key, 1.0);
184179
completionHandler.complete(key, info, response);
185180
return;
186181
}
187182

183+
if(isCancelled()){
184+
ResponseInfo i = ResponseInfo.cancelled();
185+
completionHandler.complete(key, i, null);
186+
return;
187+
}
188+
188189
if (info.needRetry() && retried < config.retryMax) {
189190
nextTask(offset, retried + 1, host);
190191
return;

0 commit comments

Comments
 (0)