Skip to content

Commit 9e54f2f

Browse files
author
YangSen-qn
committed
log utils default to not enable
1 parent adc15a5 commit 9e54f2f

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

library/src/androidTest/java/com/qiniu/android/BaseTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.qiniu.android;
22

3+
import com.qiniu.android.utils.LogUtil;
4+
35
import junit.framework.TestCase;
46

57
import java.util.Date;
@@ -11,6 +13,12 @@
1113
*/
1214
public class BaseTest extends TestCase {
1315

16+
@Override
17+
protected void setUp() throws Exception {
18+
super.setUp();
19+
LogUtil.enableLog(true);
20+
}
21+
1422
private long maxWaitTimestamp = 0;
1523
/**
1624
* waitCondition: 等待条件

library/src/androidTest/java/com/qiniu/android/LogUtilsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ public class LogUtilsTest extends BaseTest {
66

77
public void testLog(){
88

9+
LogUtil.enableLog(true);
10+
911
Throwable throwable = new Throwable();
1012

1113
assertTrue(LogUtil.v("log") > 0);

library/src/main/java/com/qiniu/android/utils/LogUtil.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*/
1010
public class LogUtil {
1111

12-
private static boolean enableLog = Utils.isDebug();
12+
private static boolean enableLog = false;
1313
private static int logLevel = Log.VERBOSE;
1414
private static boolean enableDate = false;
1515
private static boolean enableFile = true;
@@ -253,10 +253,10 @@ private static int println(int logLevel, String tag, String msg, Throwable tr) {
253253
}
254254

255255
private static boolean shouldLog(int logLevel, String tag, String msg, Throwable tr) {
256-
if (logLevel < LogUtil.logLevel || (msg == null || msg.length() == 0) && tr == null) {
256+
if (!enableLog || logLevel < LogUtil.logLevel || ((msg == null || msg.length() == 0) && tr == null)) {
257257
return false;
258258
} else {
259-
return enableLog;
259+
return true;
260260
}
261261
}
262262

0 commit comments

Comments
 (0)