Skip to content

Commit bcced12

Browse files
author
JemyCheung
committed
error_type
1 parent 1cfc909 commit bcced12

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

library/src/main/java/com/qiniu/android/collect/UploadInfoElement.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -508,14 +508,18 @@ public long getUp_time() {
508508
}
509509

510510

511-
public static String resultCode(int statuscode) {
511+
public static String resultCode(int statuscode, String error) {
512512
String result = "";
513513
switch (statuscode) {
514514
case 200:
515515
result = "ok";
516516
break;
517517
case ResponseInfo.NetworkError:
518-
result = "network_error";
518+
if (error != null && error.indexOf("but received") != -1) {
519+
result = "file_changed";
520+
} else {
521+
result = "network_error";
522+
}
519523
break;
520524
case ResponseInfo.Cancelled:
521525
result = "user_canceled";
@@ -554,14 +558,18 @@ public static String resultCode(int statuscode) {
554558
return result;
555559
}
556560

557-
public static String errorType(int statuscode) {
561+
public static String errorType(int statuscode, String error) {
558562
String result = "";
559563
if (200 < statuscode && statuscode < 600) {
560564
return "response_error";
561565
}
562566
switch (statuscode) {
563567
case ResponseInfo.NetworkError:
564-
result = "network_error";
568+
if (error != null && error.indexOf("but received") != -1) {
569+
result = "file_changed";
570+
} else {
571+
result = "network_error";
572+
}
565573
break;
566574
case ResponseInfo.Cancelled:
567575
result = "user_canceled";

library/src/main/java/com/qiniu/android/http/ResponseInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ public String toRecordMsg() {
166166
logHandler.send("prefetched_ip_count", (long) resolveResults.size());
167167
}
168168
if (error != null) {
169-
logHandler.send("error_type", UploadInfoElement.errorType(statusCode));
169+
logHandler.send("error_type", UploadInfoElement.errorType(statusCode, error));
170170
logHandler.send("error_description", error);
171171
}
172172

library/src/main/java/com/qiniu/android/storage/UploadManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ public void complete(final String key, final ResponseInfo res, final JSONObject
343343
@Override
344344
public String toRecordMsg() {
345345
LogHandler logHandler = UploadInfoElementCollector.getUplogHandler(UploadInfo.getUploadQuality());
346-
logHandler.send("result", UploadInfoElement.resultCode(res.statusCode));
346+
logHandler.send("result", UploadInfoElement.resultCode(res.statusCode, res.error));
347347
logHandler.send("total_elapsed_time", after - before);
348348
logHandler.send("requests_counts", res.requests_count);
349349
logHandler.send("bytes_sent", res.bytes_sent);

0 commit comments

Comments
 (0)