Skip to content

Commit e573125

Browse files
author
YangSen-qn
committed
optimize region request metrics
1 parent 9ad4467 commit e573125

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

library/src/androidTest/java/com/qiniu/android/ComplexUploadSceneTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ public void testMutiUploadV1(){
3030
param.completeCount = 0;
3131
param.successCount = 0;
3232

33-
for (int i = 35; i < maxCount; i++) {
33+
final int start = 30;
34+
for (int i = start; i < maxCount; i++) {
3435
Configuration config = new Configuration.Builder()
3536
.resumeUploadVersion(Configuration.RESUME_UPLOAD_VERSION_V1)
3637
.useConcurrentResumeUpload(true)
@@ -55,7 +56,7 @@ public void complete(String key, ResponseInfo info, JSONObject response) {
5556
if (info != null && info.isOK()){
5657
param.successCount += 1;
5758
}
58-
if (param.completeCount == maxCount){
59+
if (param.completeCount == (maxCount - start)){
5960
signal.countDown();
6061
}
6162
}
@@ -80,7 +81,8 @@ public void testMutiUploadV2(){
8081
param.completeCount = 0;
8182
param.successCount = 0;
8283

83-
for (int i = 35; i < maxCount; i++) {
84+
final int start = 30;
85+
for (int i = start; i < maxCount; i++) {
8486
Configuration config = new Configuration.Builder()
8587
.resumeUploadVersion(Configuration.RESUME_UPLOAD_VERSION_V2)
8688
.useConcurrentResumeUpload(true)
@@ -105,7 +107,7 @@ public void complete(String key, ResponseInfo info, JSONObject response) {
105107
if (info != null && info.isOK()){
106108
param.successCount += 1;
107109
}
108-
if (param.completeCount == maxCount){
110+
if (param.completeCount == (maxCount - start)){
109111
signal.countDown();
110112
}
111113
}
@@ -119,7 +121,7 @@ public void complete(String key, ResponseInfo info, JSONObject response) {
119121
}
120122

121123
Log.d("ComplexUploadSceneTest", "complex_upload_v2 successCount: " + param.successCount);
122-
assertTrue("success count" + param.successCount, param.successCount == param.completeCount);
124+
assertTrue("success count" + param.successCount, param.successCount == (param.completeCount));
123125
}
124126

125127

library/src/main/java/com/qiniu/android/http/metrics/UploadRegionRequestMetrics.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22

33
import com.qiniu.android.http.request.IUploadRegion;
44

5-
import java.util.ArrayList;
5+
import java.util.List;
6+
import java.util.concurrent.CopyOnWriteArrayList;
67

78
public class UploadRegionRequestMetrics {
89

910
public final IUploadRegion region;
10-
private ArrayList <UploadSingleRequestMetrics> metricsList = new ArrayList<>();
11+
private List<UploadSingleRequestMetrics> metricsList = new CopyOnWriteArrayList<>();
1112

1213
public UploadRegionRequestMetrics(IUploadRegion region) {
1314
this.region = region;
@@ -43,7 +44,7 @@ public Long bytesSend(){
4344
return bytes;
4445
}
4546

46-
public void addMetricsList(ArrayList<UploadSingleRequestMetrics> metricsList){
47+
public void addMetricsList(List<UploadSingleRequestMetrics> metricsList){
4748
if (metricsList == null || metricsList.size() == 0){
4849
return;
4950
}

0 commit comments

Comments
 (0)