Skip to content

Commit a39495b

Browse files
authored
优化上传 Error 类型 (#510)
* 类型优化
1 parent c30a037 commit a39495b

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/errors/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class QiniuRequestError extends QiniuError {
5151
* @description 由于跨域、证书错误、断网、host 解析失败、系统拦截等原因导致的错误
5252
*/
5353
export class QiniuNetworkError extends QiniuRequestError {
54-
constructor(message: string, reqId: string = '') {
54+
constructor(reqId = '', message: string) {
5555
super(0, reqId, message)
5656
}
5757
}

src/upload/index.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import Resume from './resume'
22
import Direct from './direct'
33
import Logger from '../logger'
4-
import { QiniuError } from '../errors'
4+
import { QiniuError, QiniuNetworkError, QiniuRequestError } from '../errors'
55
import { UploadCompleteData } from '../api'
66
import { Observable, IObserver, MB, normalizeUploadConfig } from '../utils'
7-
import { Extra, UploadOptions, UploadHandlers, UploadProgress, InternalConfig } from './base'
7+
import { Extra, UploadOptions, UploadHandlers, UploadProgress, Config } from './base'
88
import { HostPool } from './hosts'
99

1010
export * from './base'
@@ -43,8 +43,8 @@ export default function upload(
4343
key: string | null | undefined,
4444
token: string,
4545
putExtra?: Partial<Extra>,
46-
config?: Partial<InternalConfig>
47-
): Observable<UploadProgress, QiniuError, UploadCompleteData> {
46+
config?: Config
47+
): Observable<UploadProgress, QiniuError | QiniuRequestError | QiniuNetworkError, UploadCompleteData> {
4848

4949
// 为每个任务创建单独的 Logger
5050
const logger = new Logger(token, config?.disableStatisticsReport, config?.debugLogLevel, file.name)
@@ -60,7 +60,7 @@ export default function upload(
6060
// 创建 host 池
6161
const hostPool = new HostPool(options.config.uphost)
6262

63-
return new Observable((observer: IObserver<UploadProgress, QiniuError, UploadCompleteData>) => {
63+
return new Observable((observer: IObserver<UploadProgress, QiniuError | QiniuRequestError | QiniuNetworkError, UploadCompleteData>) => {
6464
const manager = createUploadManager(options, {
6565
onData: (data: UploadProgress) => observer.next(data),
6666
onError: (err: QiniuError) => observer.error(err),

0 commit comments

Comments
 (0)